Return-Path: Delivered-To: apmail-incubator-cassandra-dev-archive@minotaur.apache.org Received: (qmail 41254 invoked from network); 10 Dec 2009 03:15:38 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 10 Dec 2009 03:15:38 -0000 Received: (qmail 57492 invoked by uid 500); 10 Dec 2009 03:15:37 -0000 Delivered-To: apmail-incubator-cassandra-dev-archive@incubator.apache.org Received: (qmail 57477 invoked by uid 500); 10 Dec 2009 03:15:37 -0000 Mailing-List: contact cassandra-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cassandra-dev@incubator.apache.org Delivered-To: mailing list cassandra-dev@incubator.apache.org Received: (qmail 57467 invoked by uid 99); 10 Dec 2009 03:15:37 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2009 03:15:37 +0000 X-ASF-Spam-Status: No, hits=-0.0 required=10.0 tests=SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of jbellis@gmail.com designates 209.85.219.210 as permitted sender) Received: from [209.85.219.210] (HELO mail-ew0-f210.google.com) (209.85.219.210) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 10 Dec 2009 03:15:29 +0000 Received: by ewy2 with SMTP id 2so6269662ewy.27 for ; Wed, 09 Dec 2009 19:15:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :from:date:message-id:subject:to:content-type :content-transfer-encoding; bh=Yx5Gn2KBzqoC/T+72HJUlBw0fqJfrZjfs/X2RWq6ddQ=; b=ECFdyeFIksbb5f1M5o5a5jaKmD8QGeQrx4AZAoaSuSAYhcTv7ekuxI/kDCZVqYDFjb +yYBa8bFJmSVLp+106374Uxqevp6flv4GcNp1uhAdk+W8Yzo8LAlNhD6EfcBXPxiwP5v 4fDqRrtFGsIFPb7lGI8xHg7PQHRGNPA4o75bY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; b=GW55XhzjPWJsTt+Hw95ZUbfH8jgnnOFhg8ljXKBgNhj9472FOn7UuWnVOVyN5NYIxn 82j2R8XVhYayFQX2AMLbB9xtlt8qWFJgHim58A3e6rswankw69Un7/1Tk0taEc8unbq5 3qVhFz6n611fGHl7TzKxHHVNvLdKjVtDDU234= MIME-Version: 1.0 Received: by 10.216.88.78 with SMTP id z56mr3666113wee.37.1260414909113; Wed, 09 Dec 2009 19:15:09 -0800 (PST) In-Reply-To: <9e9cb550912091853m36487b2bjf8c52c1f1c0eeca7@mail.gmail.com> References: <9e9cb550912091853m36487b2bjf8c52c1f1c0eeca7@mail.gmail.com> From: Jonathan Ellis Date: Wed, 9 Dec 2009 21:14:49 -0600 Message-ID: Subject: Re: dead code: org.apache.cassandra.net.sink.SinkManager To: cassandra-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Virus-Checked: Checked by ClamAV on apache.org The authors of that class said (in a presentation?) that it's used to introduce artificial errors for testing. So I'm in no hurry to delete it. On Wed, Dec 9, 2009 at 8:53 PM, Kelvin Kakugawa wrote: > I've been looking around the codebase, and I was wondering if these > classes are dead code: > org.apache.cassandra.net.sink.IMessageSink > org.apache.cassandra.net.sink.SinkManager > > There are a couple places where SinkManager is used, however, > addMessageSink() is never called. =A0So, the calls to > process*MessageSink() appear to be no-ops. > > -Kelvin >