incubator-cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jonathan Ellis <jbel...@gmail.com>
Subject Re: Thrift API and SlicePredicate bug?
Date Fri, 14 Aug 2009 15:39:58 GMT
But that's exactly what thrift is supposed to be generating for us --
it has the concept of required/optional; only optional fields should
be null-able.

I've attached a patch to
https://issues.apache.org/jira/browse/THRIFT-562 to fix this.

On Fri, Aug 14, 2009 at 5:53 AM, Sergio Bossa<sergio.bossa@gmail.com> wrote:
> On Thu, Aug 13, 2009 at 2:48 PM, Jonathan Ellis<jbellis@gmail.com> wrote:
>
>> you're giving garbage as a slice predicate.  thrift should error check
>> that but does not.
>
> I took a look at the source code (CassandraServer) but it doesn't seem
> a ThriftValidation issue: I'd rather check for null (somewhat as you
> do with range.count) and throw an InvalidRequestException in case of
> ... what do you think?
>
> Cheers,
>
> Sergio B.
>
> --
> Sergio Bossa
> Software Passionate and Open Source Enthusiast.
> URL: http://www.linkedin.com/in/sergiob
>

Mime
View raw message