Return-Path: Delivered-To: apmail-incubator-cassandra-dev-archive@minotaur.apache.org Received: (qmail 14611 invoked from network); 2 Apr 2009 23:38:06 -0000 Received: from hermes.apache.org (HELO mail.apache.org) (140.211.11.3) by minotaur.apache.org with SMTP; 2 Apr 2009 23:38:06 -0000 Received: (qmail 18403 invoked by uid 500); 2 Apr 2009 23:38:06 -0000 Delivered-To: apmail-incubator-cassandra-dev-archive@incubator.apache.org Received: (qmail 18375 invoked by uid 500); 2 Apr 2009 23:38:05 -0000 Mailing-List: contact cassandra-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: cassandra-dev@incubator.apache.org Delivered-To: mailing list cassandra-dev@incubator.apache.org Received: (qmail 18365 invoked by uid 99); 2 Apr 2009 23:38:05 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2009 23:38:05 +0000 X-ASF-Spam-Status: No, hits=2.2 required=10.0 tests=HTML_MESSAGE,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of avinash.lakshman@gmail.com designates 209.85.146.178 as permitted sender) Received: from [209.85.146.178] (HELO wa-out-1112.google.com) (209.85.146.178) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 02 Apr 2009 23:37:57 +0000 Received: by wa-out-1112.google.com with SMTP id n7so440926wag.12 for ; Thu, 02 Apr 2009 16:37:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:in-reply-to:references :date:message-id:subject:from:to:content-type; bh=jZ/pWXTlF9DY/tVd0mpc3HdQf+ROniznVGKJJkoTEIE=; b=i68hm7Eo885WvXEApIuecpKlzA2yR2S/CVsgGjqprLdVBRCTuK3vBqDkQKohUjfbTu //sJl2DoAag+wAnXkT4XPgHDxVq8NUotTL7cPLP6/ChASIdpRYmO499LL2CgCkBuvrA4 qu1a/MvyppSL/WQ42QoH47tZQvaiZNDFSk+sw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:in-reply-to:references:date:message-id:subject:from:to :content-type; b=OGhBalyCW1HNtJ7L8Aj2XoqiKai5cKym+ELkB6BVA+md48A14kxYdl1sAbKlwepsl/ hLVusLivwKX1FiGC3USx9fuTQSBuv5pYWF+Yi9bg3gQL2WSEvYR+DMd7SwkBcDk8Qj2a 4+QdmErEiwMmSF1NFIZhWwlE9tz/omul1N15o= MIME-Version: 1.0 Received: by 10.114.205.14 with SMTP id c14mr241737wag.226.1238715456459; Thu, 02 Apr 2009 16:37:36 -0700 (PDT) In-Reply-To: References: Date: Thu, 2 Apr 2009 16:37:36 -0700 Message-ID: Subject: Re: Random Checkins From: Avinash Lakshman To: cassandra-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=001485f99d8ec2937104669aea22 X-Virus-Checked: Checked by ClamAV on apache.org --001485f99d8ec2937104669aea22 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Another issue with ConcurrentHashMap is that the dude is a memory hog. We got rid of it over a year ago because of the very same reason. Also for everything that is done there is a reason. I think we are not asking for much to apart from run it by someone before what are basically changes that suit your style. There is a reason why something is done the way it is - we have been at this for over a year and half. I understand the community business but it has to be established that random changes need to be under check. At this rate everyone can just go trigger happy w/o any process in place. It is important that this is realized. Avinash On Thu, Apr 2, 2009 at 3:52 PM, Avinash Lakshman wrote: > Compactions etc are breaking now in our tests. I am going to revert all new > commits that have gone in. Are you sure these are tested changes? We need to > have a review process for changing code that is functioning. This is very > very frustrating. > > Avinash > --001485f99d8ec2937104669aea22--