incubator-cassandra-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Zhu Han <schumi....@gmail.com>
Subject Re: Random Checkins
Date Sat, 04 Apr 2009 07:48:29 GMT
+1 for this proposal.

best regards,
hanzhu


On Fri, Apr 3, 2009 at 10:52 AM, Ian Holsman <ian@holsman.net> wrote:

>
>
> ideally the test cases that your working with could be made public, but
> until then is it possible for you to run a hudson like service inside of FB
> and mail the test result output to the list so people know that tests are
> failing.
>
>
> On 03/04/2009, at 1:21 PM, Jonathan Ellis wrote:
>
>  On Thu, Apr 2, 2009 at 6:37 PM, Avinash Lakshman
>> <avinash.lakshman@gmail.com> wrote:
>>
>>> Another issue with ConcurrentHashMap is that the dude is a memory hog. We
>>> got rid of it over a year ago because of the very same reason.
>>>
>>
>> Re CHM: what do you suggest instead?  I assume you are talking about
>> for EfficientBidiMap.  Do you want the Getter to return a copy of the
>> ColumnFamily and stick with non-concurrent structures?  Or use
>> NonBlockingHashMap?
>>
>>  Also for
>>> everything that is done there is a reason.
>>>
>>
>> I don't see any harm in, for instance, me making a commit, you saying
>> "ConcurrentHashMap is a memory hog", and me saying, "okay, what do you
>> suggest instead?"  Nothing wrong with post-commit review in trunk.
>>
>>  I think we are not asking for
>>> much to apart from run it by someone before what are basically changes
>>> that
>>> suit your style.
>>>
>>
>> We've tried waiting for you or Prashant to review things.  That didn't
>> work over on the code.google project and it hasn't worked here.  My
>> remove patches sat unreviewed for weeks, literally.  More recently, a
>> request for a list of known issues and my attempt to start  a
>> conversation about a roadmap have gone without comment so far.
>>
>> I'm not trying to dump on you; we know you're busy.  But we have
>> deadlines too and we can't hold every patch waiting days or weeks for
>> a review.
>>
>> Tell you what.  I will try to get changes reviewed by someone in the
>> community before committing.  We will see how that works.  That should
>> at least give you some confidence that it's not just me off being a
>> cowboy.
>>
>> -Jonathan
>>
>
> --
> Ian Holsman
> Ian@Holsman.net
>
>
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message