Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of kingoftheoaks@hotmail.com
 designates 65.55.34.209 as permitted sender)
Message-ID: <COL002-W15E56D0C56EFA28269E94EA2740@phx.gbl>
Content-Type: multipart/alternative;
	boundary="_461aaa24-11d0-4e3e-9ec9-d2f52d95bf1e_"
From: Herm Wong <kingoftheoaks@hotmail.com>
To: "callback-dev@incubator.apache.org" <callback-dev@incubator.apache.org>
Subject: RE: cordova-js webOS
Date: Sat, 20 Oct 2012 09:07:15 -0700
Importance: Normal
In-Reply-To: 
 <CAESi+4-iEyq=wmDWTWD3rnfX5rXrHbWQ9UyZGuwXhUxbzfKWHw@mail.gmail.com>
References: 
 <7EC783583A3638449E13002CFE331D3A3235BD31@G4W3290.americas.hpqcorp.net>,<957F1ECDA90E004B8DBDE23CFC94E3A33A58DF63@XMB103ECNC.rim.net>,<7EC783583A3638449E13002CFE331D3A3235C0FC@G4W3290.americas.hpqcorp.net>,<957F1ECDA90E004B8DBDE23CFC94E3A33A58E008@XMB103ECNC.rim.net>,<7EC783583A3638449E13002CFE331D3A3235C4A9@G4W3290.americas.hpqcorp.net>,<957F1ECDA90E004B8DBDE23CFC94E3A33A593C8D@XMB103ECNC.rim.net>,<CAESi+48LyWnK4pV2BoXgBif6jD_+uoH3MRh8r2aXOsNESugh_w@mail.gmail.com>
 <CANpVHHwcpzWsRMe5y=N_XHy8GzNaO=0tUN9+ej8VtQpMOk1JuA@mail.gmail.com>,<CAESi+4-iEyq=wmDWTWD3rnfX5rXrHbWQ9UyZGuwXhUxbzfKWHw@mail.gmail.com>
MIME-Version: 1.0

--_461aaa24-11d0-4e3e-9ec9-d2f52d95bf1e_
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable

I'll test it Monday when I'm back in SF (where my webOS devices are located=
).

> From: gord@tinyhippos.com
> Date: Fri=2C 19 Oct 2012 22:17:41 -0400
> Subject: Re: cordova-js webOS
> To: callback-dev@incubator.apache.org
>=20
> That wouldn't have caught it=2C the main problem was code that wasn't
> indented to the correct level=2C check out the diff to see what I did.
>=20
>=20
> On Fri=2C Oct 19=2C 2012 at 8:28 PM=2C Anis KADRI <anis.kadri@gmail.com> =
wrote:
>=20
> > I=2C myself=2C just called fixwhitespace task. Isn't that supposed to f=
ix the
> > indentation issues ? Jake stopped barking after I did it=2C so I assume=
d
> > everything was alright.
> >
> > On Fri=2C Oct 19=2C 2012 at 4:44 PM=2C Gord Tanner <gord@tinyhippos.com=
> wrote:
> >
> > > Hey=2C
> > >
> > > I took a look at the webos code and it had a number of indentation is=
sues
> > > and some other papercuts that I cleaned up on a personal branch.
> > >
> > >
> > >
> > https://github.com/gtanner/incubator-cordova-js/commit/d123863e089dc5f9=
98d68c2867d2bc17636262ab
> > >
> > > I don't have a webos device to test that everything still works but i=
t
> > > should since most of what I fixed was just cleaning up the code
> > formatting
> > > issues.
> > >
> > > Could someone with a webos device do a quick test of this branch to s=
ee
> > if
> > > it still works and we can get this merged in to master.
> > >
> > > Thanks=2C
> > >
> > > Gord
> > >
> > > On Fri=2C Oct 12=2C 2012 at 12:02 PM=2C Josh Soref <jsoref@rim.com> w=
rote:
> > >
> > > > Markus wrote:
> > > > > Fixed=2C every file has now a new line at the end
> > > >
> > > > As a vcs purity note=2C your fix for this had an unrelated change i=
n the
> > > > commit:
> > > >
> > > >
> > > >
> > >
> > https://github.com/ghtomcat/incubator-cordova-js/commit/3acbb8d99207bd9=
b1163b71734f4e999bd4d6512#L1L23
> > > >
> > > > @@ -20=2C7 +20=2C6 @@ var plugins =3D {
> > > > -    /*"File" : require('cordova/plugin/webos/filereader')=2C*/
> > > >
> > > > @@ -35=2C4 +34=2C4 @@ module.exports =3D function(success=2C fail=
=2C service=2C
> > > > action=2C args) {
> > > > -}=3B
> > > > \ No newline at end of file
> > > > +}=3B
> > > >
> > > > Personally=2C I'd rewrite all the changesets:
> > > > * folding in the newlines into the original commit
> > > > * possibly keeping the indentation consistency thing as a distinct
> > >  commit
> > > > * definitely splitting the comment removal into its own commit if i=
t is
> > > > meaningful=2C or folding it into the original commit otherwise.
> > > >
> > > > -- but this is easy for me to do with mercurial and would probably
> > result
> > > > in me pulling more hairs with git -- and it would give me the pain =
of
> > > > trying to figure out if I need to close/open new pull requests with
> > > github
> > > > whose ui inevitably trips me up.
> > > >
> > > > -------------------------------------------------------------------=
--
> > > > This transmission (including any attachments) may contain confident=
ial
> > > > information=2C privileged material (including material protected by=
 the
> > > > solicitor-client or other applicable privileges)=2C or constitute
> > > non-public
> > > > information. Any use of this information by anyone other than the
> > > intended
> > > > recipient is prohibited. If you have received this transmission in
> > error=2C
> > > > please immediately reply to the sender and delete this information =
from
> > > > your system. Use=2C dissemination=2C distribution=2C or reproductio=
n of this
> > > > transmission by unintended recipients is not authorized and may be
> > > unlawful.
> > > >
> > >
> > >
> > >
> > > --
> > > Gord Tanner
> > > Senior Developer / Code Poet
> > > tinyHippos Inc.
> > > @tinyhippos
> > >
> >
>=20
>=20
>=20
> --=20
> Gord Tanner
> Senior Developer / Code Poet
> tinyHippos Inc.
> @tinyhippos
 		 	   		  =

--_461aaa24-11d0-4e3e-9ec9-d2f52d95bf1e_--