Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: neutral (nike.apache.org: local policy)
From: Josh Soref <jsoref@rim.com>
To: "callback-dev@incubator.apache.org" <callback-dev@incubator.apache.org>
Subject: RE: cordova-js webOS
Thread-Topic: cordova-js webOS
Thread-Index: Ac2nt7YzaKDJQg2FTgKE6dy5a8ifWAACLx8AAAE5F6AAALno8AAgxOuQABG8sVA=
Date: Fri, 12 Oct 2012 16:02:18 +0000
Message-ID: <957F1ECDA90E004B8DBDE23CFC94E3A33A593C8D@XMB103ECNC.rim.net>
References: 
 <7EC783583A3638449E13002CFE331D3A3235BD31@G4W3290.americas.hpqcorp.net>
 <957F1ECDA90E004B8DBDE23CFC94E3A33A58DF63@XMB103ECNC.rim.net>
 <7EC783583A3638449E13002CFE331D3A3235C0FC@G4W3290.americas.hpqcorp.net>
 <957F1ECDA90E004B8DBDE23CFC94E3A33A58E008@XMB103ECNC.rim.net>
 <7EC783583A3638449E13002CFE331D3A3235C4A9@G4W3290.americas.hpqcorp.net>
In-Reply-To: 
 <7EC783583A3638449E13002CFE331D3A3235C4A9@G4W3290.americas.hpqcorp.net>
Accept-Language: en-US, en-CA
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
content-transfer-encoding: quoted-printable
MIME-Version: 1.0

Markus wrote:
> Fixed, every file has now a new line at the end

As a vcs purity note, your fix for this had an unrelated change in the commi=
t:

https://github.com/ghtomcat/incubator-cordova-js/commit/3acbb8d99207bd9b1163=
b71734f4e999bd4d6512#L1L23

@@ -20,7 +20,6 @@ var plugins =3D {
-    /*"File" : require('cordova/plugin/webos/filereader'),*/

@@ -35,4 +34,4 @@ module.exports =3D function(success, fail, service, action=
, args) {
-}; 	  	
\ No newline at end of file
+};

Personally, I'd rewrite all the changesets:
* folding in the newlines into the original commit
* possibly keeping the indentation consistency thing as a distinct  commit
* definitely splitting the comment removal into its own commit if it is mean=
ingful, or folding it into the original commit otherwise.

-- but this is easy for me to do with mercurial and would probably result in=
 me pulling more hairs with git -- and it would give me the pain of trying t=
o figure out if I need to close/open new pull requests with github whose ui=
 inevitably trips me up.

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential infor=
mation, privileged material (including material protected by the solicitor-c=
lient or other applicable privileges), or constitute non-public information.=
 Any use of this information by anyone other than the intended recipient is=
 prohibited. If you have received this transmission in error, please immedia=
tely reply to the sender and delete this information from your system. Use,=
 dissemination, distribution, or reproduction of this transmission by uninte=
nded recipients is not authorized and may be unlawful.