Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Date: Tue, 23 Oct 2012 17:35:15 +0000 (UTC)
From: "Joe Bowser (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: <521269525.16939.1351013715479.JavaMail.jiratomcat@arcas>
In-Reply-To: <1569451992.16409.1349812323377.JavaMail.jiratomcat@arcas>
Subject: [jira] [Reopened] (CB-1611) Use browserHistory by default
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Joe Bowser reopened CB-1611:
----------------------------


I personally don't think that this is as readable as the previous version which DID work but but did miss the deprecation.  The current code is unclear beacuse we're negating a string comparison for some reason, and the string itself happens to be false.

I honestly think we should revert this back.  This was working and this is really just a style issue.
                
> Use browserHistory by default
> -----------------------------
>
>                 Key: CB-1611
>                 URL: https://issues.apache.org/jira/browse/CB-1611
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.1.0
>            Reporter: Joe Bowser
>            Assignee: Andrew Grieve
>             Fix For: 2.2.0
>
>
> Instead of using navigator.app.backHistory(), we should use history.back.  If we are using the WebView's history backHistory should still work, but use it and not the shim version.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira