incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Herm Wong <kingoftheo...@hotmail.com>
Subject RE: cordova-js webOS
Date Mon, 22 Oct 2012 21:26:10 GMT
Yeap. Tried that as well. It's looking like the exec call is being made but the banner isn't
being displayed. The palm-log isn't displaying any errors.
Will continue to debug the issue.

> From: fil@adobe.com
> To: callback-dev@incubator.apache.org
> Date: Mon, 22 Oct 2012 14:24:02 -0700
> Subject: Re: cordova-js webOS
> 
> https://github.com/apache/incubator-cordova-js/blob/master/lib/webos/exec.j
> s#L43
> 
> 
> The notification API is defined in exec with uppercase Notification in
> webOS' case. Try "Notification" as the param into exec, as per the common
> notification plugin:
> 
> https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugi
> n/notification.js#L41
> 
> 
> On 10/22/12 1:41 PM, "Herm Wong" <kingoftheoaks@hotmail.com> wrote:
> 
> >The webOS cordova-js will boot up properly and fire the deviceReady event
> >with Gord's & Anis' changes merged.
> >However I'm still having troubles getting the APIs to work.
> >For example:
> >Cordova.exec(null, null, "notification", "showBanner", "hello world");
> >returns the following error in the palm log: [20121022-11:47:05.902046]
> >error: TypeError: Cannot call method 'showBanner' of undefined,
> >cordova.webos.js:951
> >It looks like the plugin mapping isn't able to find the notification
> >class since it's undefined.
> >I also tried testing the cordova.webos.js file with the webOS kitchen
> >sink sample app and wasn't able to get the app to
> >work.https://github.com/hermwong/PhoneGap-webOS-kitchen-sink-app
> >We may want to tag cordova-js 2.2.0rc2 and release it without cordova-js
> >webOS until we're able to track down & resolve this issue.
> >
> >> From: kingoftheoaks@hotmail.com
> >> To: callback-dev@incubator.apache.org
> >> Subject: RE: cordova-js webOS
> >> Date: Sat, 20 Oct 2012 09:07:15 -0700
> >> 
> >> I'll test it Monday when I'm back in SF (where my webOS devices are
> >>located).
> >> 
> >> > From: gord@tinyhippos.com
> >> > Date: Fri, 19 Oct 2012 22:17:41 -0400
> >> > Subject: Re: cordova-js webOS
> >> > To: callback-dev@incubator.apache.org
> >> > 
> >> > That wouldn't have caught it, the main problem was code that wasn't
> >> > indented to the correct level, check out the diff to see what I did.
> >> > 
> >> > 
> >> > On Fri, Oct 19, 2012 at 8:28 PM, Anis KADRI <anis.kadri@gmail.com>
> >>wrote:
> >> > 
> >> > > I, myself, just called fixwhitespace task. Isn't that supposed to
> >>fix the
> >> > > indentation issues ? Jake stopped barking after I did it, so I
> >>assumed
> >> > > everything was alright.
> >> > >
> >> > > On Fri, Oct 19, 2012 at 4:44 PM, Gord Tanner <gord@tinyhippos.com>
> >>wrote:
> >> > >
> >> > > > Hey,
> >> > > >
> >> > > > I took a look at the webos code and it had a number of
> >>indentation issues
> >> > > > and some other papercuts that I cleaned up on a personal branch.
> >> > > >
> >> > > >
> >> > > >
> >> > > 
> >>https://github.com/gtanner/incubator-cordova-js/commit/d123863e089dc5f998
> >>d68c2867d2bc17636262ab
> >> > > >
> >> > > > I don't have a webos device to test that everything still works
> >>but it
> >> > > > should since most of what I fixed was just cleaning up the code
> >> > > formatting
> >> > > > issues.
> >> > > >
> >> > > > Could someone with a webos device do a quick test of this branch
> >>to see
> >> > > if
> >> > > > it still works and we can get this merged in to master.
> >> > > >
> >> > > > Thanks,
> >> > > >
> >> > > > Gord
> >> > > >
> >> > > > On Fri, Oct 12, 2012 at 12:02 PM, Josh Soref <jsoref@rim.com>
> >>wrote:
> >> > > >
> >> > > > > Markus wrote:
> >> > > > > > Fixed, every file has now a new line at the end
> >> > > > >
> >> > > > > As a vcs purity note, your fix for this had an unrelated
change
> >>in the
> >> > > > > commit:
> >> > > > >
> >> > > > >
> >> > > > >
> >> > > >
> >> > > 
> >>https://github.com/ghtomcat/incubator-cordova-js/commit/3acbb8d99207bd9b1
> >>163b71734f4e999bd4d6512#L1L23
> >> > > > >
> >> > > > > @@ -20,7 +20,6 @@ var plugins = {
> >> > > > > -    /*"File" : require('cordova/plugin/webos/filereader'),*/
> >> > > > >
> >> > > > > @@ -35,4 +34,4 @@ module.exports = function(success, fail,
> >>service,
> >> > > > > action, args) {
> >> > > > > -};
> >> > > > > \ No newline at end of file
> >> > > > > +};
> >> > > > >
> >> > > > > Personally, I'd rewrite all the changesets:
> >> > > > > * folding in the newlines into the original commit
> >> > > > > * possibly keeping the indentation consistency thing as
a
> >>distinct
> >> > > >  commit
> >> > > > > * definitely splitting the comment removal into its own
commit
> >>if it is
> >> > > > > meaningful, or folding it into the original commit otherwise.
> >> > > > >
> >> > > > > -- but this is easy for me to do with mercurial and would
> >>probably
> >> > > result
> >> > > > > in me pulling more hairs with git -- and it would give me
the
> >>pain of
> >> > > > > trying to figure out if I need to close/open new pull requests
> >>with
> >> > > > github
> >> > > > > whose ui inevitably trips me up.
> >> > > > >
> >> > > > > 
> >>---------------------------------------------------------------------
> >> > > > > This transmission (including any attachments) may contain
> >>confidential
> >> > > > > information, privileged material (including material protected
> >>by the
> >> > > > > solicitor-client or other applicable privileges), or constitute
> >> > > > non-public
> >> > > > > information. Any use of this information by anyone other
than
> >>the
> >> > > > intended
> >> > > > > recipient is prohibited. If you have received this transmission
> >>in
> >> > > error,
> >> > > > > please immediately reply to the sender and delete this
> >>information from
> >> > > > > your system. Use, dissemination, distribution, or reproduction
> >>of this
> >> > > > > transmission by unintended recipients is not authorized
and may
> >>be
> >> > > > unlawful.
> >> > > > >
> >> > > >
> >> > > >
> >> > > >
> >> > > > --
> >> > > > Gord Tanner
> >> > > > Senior Developer / Code Poet
> >> > > > tinyHippos Inc.
> >> > > > @tinyhippos
> >> > > >
> >> > >
> >> > 
> >> > 
> >> > 
> >> > -- 
> >> > Gord Tanner
> >> > Senior Developer / Code Poet
> >> > tinyHippos Inc.
> >> > @tinyhippos
> >>  		 	   		  
> > 		 	   		  
> 
 		 	   		  
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message