incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: [jira] [Reopened] (CB-1611) Use browserHistory by default
Date Tue, 23 Oct 2012 17:36:46 GMT
Agree, the code:

!"false"

is weird

My $0.02.

On 10/23/12 10:35 AM, "Joe Bowser (JIRA)" <jira@apache.org> wrote:

>
>     [ 
>https://issues.apache.org/jira/browse/CB-1611?page=com.atlassian.jira.plug
>in.system.issuetabpanels:all-tabpanel ]
>
>Joe Bowser reopened CB-1611:
>----------------------------
>
>
>I personally don't think that this is as readable as the previous version
>which DID work but but did miss the deprecation.  The current code is
>unclear beacuse we're negating a string comparison for some reason, and
>the string itself happens to be false.
>
>I honestly think we should revert this back.  This was working and this
>is really just a style issue.
>                
>> Use browserHistory by default
>> -----------------------------
>>
>>                 Key: CB-1611
>>                 URL: https://issues.apache.org/jira/browse/CB-1611
>>             Project: Apache Cordova
>>          Issue Type: Bug
>>          Components: Android
>>    Affects Versions: 2.1.0
>>            Reporter: Joe Bowser
>>            Assignee: Andrew Grieve
>>             Fix For: 2.2.0
>>
>>
>> Instead of using navigator.app.backHistory(), we should use
>>history.back.  If we are using the WebView's history backHistory should
>>still work, but use it and not the shim version.
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA
>administrators
>For more information on JIRA, see: http://www.atlassian.com/software/jira


Mime
View raw message