incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Camera Update
Date Sun, 07 Oct 2012 14:25:10 GMT
How do you suggest doing a code review?

I've taken to making dummy pull requests (not even necessarily to the
official repo), just to enable the github inline-comments-on-diff
functionality as ask people to review that way.  Is there a better way?

-Michal


On Fri, Oct 5, 2012 at 7:44 PM, Joe Bowser <bowserj@gmail.com> wrote:

> Hey
>
> I've updated the Camera code and we have some UI assets for our
> camera.  It's still buggy, but here is my latest:
>
> https://github.com/infil00p/callback-android/tree/camera
>
> I just realized that none of this is being tracked in JIRA.  It'd be
> good to review this code more and to tweak this before I go code up
> the UI so we can pack this thing into a JAR.  I'll add the JIRA tasks
> in a bit.
>
> Joe
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message