incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Gord Tanner <g...@tinyhippos.com>
Subject Re: cordova-js webOS
Date Fri, 19 Oct 2012 23:44:09 GMT
Hey,

I took a look at the webos code and it had a number of indentation issues
and some other papercuts that I cleaned up on a personal branch.

https://github.com/gtanner/incubator-cordova-js/commit/d123863e089dc5f998d68c2867d2bc17636262ab

I don't have a webos device to test that everything still works but it
should since most of what I fixed was just cleaning up the code formatting
issues.

Could someone with a webos device do a quick test of this branch to see if
it still works and we can get this merged in to master.

Thanks,

Gord

On Fri, Oct 12, 2012 at 12:02 PM, Josh Soref <jsoref@rim.com> wrote:

> Markus wrote:
> > Fixed, every file has now a new line at the end
>
> As a vcs purity note, your fix for this had an unrelated change in the
> commit:
>
>
> https://github.com/ghtomcat/incubator-cordova-js/commit/3acbb8d99207bd9b1163b71734f4e999bd4d6512#L1L23
>
> @@ -20,7 +20,6 @@ var plugins = {
> -    /*"File" : require('cordova/plugin/webos/filereader'),*/
>
> @@ -35,4 +34,4 @@ module.exports = function(success, fail, service,
> action, args) {
> -};
> \ No newline at end of file
> +};
>
> Personally, I'd rewrite all the changesets:
> * folding in the newlines into the original commit
> * possibly keeping the indentation consistency thing as a distinct  commit
> * definitely splitting the comment removal into its own commit if it is
> meaningful, or folding it into the original commit otherwise.
>
> -- but this is easy for me to do with mercurial and would probably result
> in me pulling more hairs with git -- and it would give me the pain of
> trying to figure out if I need to close/open new pull requests with github
> whose ui inevitably trips me up.
>
> ---------------------------------------------------------------------
> This transmission (including any attachments) may contain confidential
> information, privileged material (including material protected by the
> solicitor-client or other applicable privileges), or constitute non-public
> information. Any use of this information by anyone other than the intended
> recipient is prohibited. If you have received this transmission in error,
> please immediately reply to the sender and delete this information from
> your system. Use, dissemination, distribution, or reproduction of this
> transmission by unintended recipients is not authorized and may be unlawful.
>



-- 
Gord Tanner
Senior Developer / Code Poet
tinyHippos Inc.
@tinyhippos

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message