incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Brian LeRoux...@brian.io>
Subject Re: Pluginstall tool discussion
Date Sat, 06 Oct 2012 09:22:52 GMT
Think its time we nominated a canonical repo for this. Fil's?

On Fri, Oct 5, 2012 at 11:41 AM, Mike Reinstein
<reinstein.mike@gmail.com> wrote:
> Thanks for scribing the meeting Fil. Here are some updates:
>
> Anis and I realized after the meeting that there were still some
> disagreement points. Our main disagreement was over the plugin.xml changes;
> I wanted to do them now, and Anis wanted to wait. After discussing with
> Fil, Anis, and myself, we decided to compromise by merging in all of my
> changes *except for* plugin namespacing, and plugin.xml/plugin directory
> changes. The reasoning being:
> a) we really need to work off the same basic codebase, which is beginning o
> diverge dramatically
> b) we'd like to get the pg build team to use our code as well, so pg build
> doesnt diverge from cordova cli efforts. Fil pointed out that not changing
> the plugin format at this point in time  makes this much easier in the
> short term.
>
> We also re-iterated that the plugin changes are wanted improvements, and
> after succesfully merging, Fil will work with the build team to get buy-in.
> In the meantime I'll branch the code and add my plugin format changes there
> so when we're ready we can merge them into master.
>
> Fil, Anis, I just sent a pull request with all my changes (minus plugin
> formatting and namespacing) via github:
> https://github.com/imhotep/pluginstall/pull/1
> I'd really appreciate some feedback on this so we can get it merged. I dont
> want to create that branch containing the plugin changes until after the
> merge is complete.
>
> -Mike
>
> On Tue, Oct 2, 2012 at 6:34 PM, Filip Maj <fil@adobe.com> wrote:
>
>> Recap of the meeting:
>>
>> - Mike's + Anis' forks of pluginstall to be merged
>> - the cli api will tend toward Mike's slightly more verbose interface
>> - also included in all of this are Mike's changes to the plugin.xml spec.
>> includes eliminating some verbosity and going the implicit route where
>> possible (I.e. Source code target location for java files, for example).
>> Renames to a few plugin.xml elements included (I.e. Config-change to
>> xml-graft)
>> - trying to formalize a good starting point for plugin authors, some kind
>> of skeleton to work off of. Cordova-echo plugin (per the docs) does seem
>> like a good starting point for this.
>>
>> On 10/2/12 12:05 PM, "Mike Reinstein" <reinstein.mike@gmail.com> wrote:
>>
>> >I'm thinking about screen casting as we walk through the changes. If it
>> >happens I'll email a link here so anyone thats interested can follow along
>> >visually with the code review/discussion.
>> >
>> >
>> >
>> >On Tue, Oct 2, 2012 at 2:48 PM, Filip Maj <fil@adobe.com> wrote:
>> >
>> >> Valuable info..
>> >>
>> >> 2PM PDT!
>> >>
>> >> On 10/2/12 11:42 AM, "Michal Mocny" <mmocny@chromium.org> wrote:
>> >>
>> >> >When?
>> >> >
>> >> >
>> >> >On Tue, Oct 2, 2012 at 2:34 PM, Filip Maj <fil@adobe.com> wrote:
>> >> >
>> >> >> FYI, Mike, Anis and I will be discussing the pluginstall tool.
Anis
>> >>has
>> >> >> made many improvements, including adding plugin removal. Mike has
>> >>also
>> >> >> done a lot of work and fixed a variety of different issues. However,
>> >> >>their
>> >> >> work is diverging, so we are going to discuss the differences between
>> >> >> their forks and set a plan on how to get their code bases merged.
>> >>Also
>> >> >> will touch on the API for this tool. Feel free to join in the
>> >> >>discussion!
>> >> >> I will report back notes to ML after.
>> >> >>
>> >> >> Call in info
>> >> >> ------------
>> >> >>
>> >> >> Conference code:
>> >> >> 5566718809
>> >> >>
>> >> >> Access Numbers:
>> >> >>
>> >> >> Toll-free dial-in number (U.S. and Canada):
>> >> >>
>> >> >> (855) 870-5454
>> >> >>
>> >> >> International dial-in number:
>> >> >> (408) 773-6768
>> >> >>
>> >> >>
>> >>
>> >>
>>
>>

Mime
View raw message