incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Josh Soref <jso...@rim.com>
Subject RE: cordova-js webOS
Date Fri, 12 Oct 2012 16:02:18 GMT
Markus wrote:
> Fixed, every file has now a new line at the end

As a vcs purity note, your fix for this had an unrelated change in the commit:

https://github.com/ghtomcat/incubator-cordova-js/commit/3acbb8d99207bd9b1163b71734f4e999bd4d6512#L1L23

@@ -20,7 +20,6 @@ var plugins = {
-    /*"File" : require('cordova/plugin/webos/filereader'),*/

@@ -35,4 +34,4 @@ module.exports = function(success, fail, service, action, args) {
-}; 	  	
\ No newline at end of file
+};

Personally, I'd rewrite all the changesets:
* folding in the newlines into the original commit
* possibly keeping the indentation consistency thing as a distinct  commit
* definitely splitting the comment removal into its own commit if it is meaningful, or folding
it into the original commit otherwise.

-- but this is easy for me to do with mercurial and would probably result in me pulling more
hairs with git -- and it would give me the pain of trying to figure out if I need to close/open
new pull requests with github whose ui inevitably trips me up.

---------------------------------------------------------------------
This transmission (including any attachments) may contain confidential information, privileged
material (including material protected by the solicitor-client or other applicable privileges),
or constitute non-public information. Any use of this information by anyone other than the
intended recipient is prohibited. If you have received this transmission in error, please
immediately reply to the sender and delete this information from your system. Use, dissemination,
distribution, or reproduction of this transmission by unintended recipients is not authorized
and may be unlawful.

Mime
View raw message