incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1600) [ios] crash in MobileSpec under 4.3 during file transfer
Date Tue, 09 Oct 2012 19:42:03 GMT

    [ https://issues.apache.org/jira/browse/CB-1600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472672#comment-13472672
] 

Patrick Mueller commented on CB-1600:
-------------------------------------

I've added some code which prevents the crash - pre-checking the white list, and extra protection
before casting the NSURLResponse to NSHTTPURLResponse, just in case ...

Since I'm not completely comfortable with this code, figured I'd push the commit as a pull
request - hopefully someone can review this and make sure it's ok.

https://github.com/apache/incubator-cordova-ios/pull/57
                
> [ios] crash in MobileSpec under 4.3 during file transfer
> --------------------------------------------------------
>
>                 Key: CB-1600
>                 URL: https://issues.apache.org/jira/browse/CB-1600
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>            Reporter: Patrick Mueller
>            Assignee: Andrew Grieve
>
> I've run Mobile Spec under iOS 4.3 (Xcode 4.5.1 on Lion), and noticed a consistent trap.
 
> The problem occurs in [CDVFileTransfer.m:477|https://github.com/apache/incubator-cordova-ios/blob/master/CordovaLib/Classes/CDVFileTransfer.m#L477]
in method {{- (void)connection:(NSURLConnection*)connection didReceiveResponse:(NSURLResponse*)response}}.
 
> As near as I can tell, from the debugger, the object coming in as the response is not
actually an NSHTTPURLResponse, and that's where the crash is - when it asks for the statusCode.
 Cast that didn't work, but you don't find out till you try to access something that's not
there.
> Other debugger info:
> response expectedContentLength == -1
> response URL == http://cordova-filetransfer.jitsu.com/robots.txt

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message