incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pmuellr <...@git.apache.org>
Subject incubator-cordova-ios pull request: CB-1600 - fix crash on iOS 4.3 in file ...
Date Tue, 09 Oct 2012 19:37:25 GMT
GitHub user pmuellr opened a pull request:

    https://github.com/apache/incubator-cordova-ios/pull/57

    CB-1600 - fix crash on iOS 4.3 in file transfer

    https://issues.apache.org/jira/browse/CB-1600
    
    Did two basic things here:
    
    1) add whitelist check before CDVFileTransfer#download/upload even start,
    to prevent the confusing behavior of whitelist checking in the middle of
    the download
    
    2) in the case where the whitelist passes, but gets one of the error
    conditions that we originally saw the crash in, add some extra protection
    to the cast in CDVFileTransfer#connection:didReceiveResponse:
    of NSURLResponse to NSHTTPURLResponse, since sometimes it isn't one.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pmuellr/incubator-cordova-ios CB-1600

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-cordova-ios/pull/57.patch

----
commit 7589751f49ef22b4f6c973ab44f618967c5f034f
Author: Patrick Mueller <pmuellr@apache.org>
Date:   2012-10-09T12:23:52-07:00

    CB-1600 - fix crash on iOS 4.3 in file transfer
    
    https://issues.apache.org/jira/browse/CB-1600
    
    Did two basic things here:
    
    1) add whitelist check before CDVFileTransfer#download/upload even start,
    to prevent the confusing behavior of whitelist checking in the middle of
    the download
    
    2) in the case where the whitelist passes, but gets one of the error
    conditions that we originally saw the crash in, add some extra protection
    to the cast in CDVFileTransfer#connection:didReceiveResponse:
    of NSURLResponse to NSHTTPURLResponse, since sometimes it isn't one.

----


Mime
View raw message