incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1604) natigator.connection not implemented correctly on iOS
Date Tue, 09 Oct 2012 16:26:03 GMT

    [ https://issues.apache.org/jira/browse/CB-1604?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13472515#comment-13472515
] 

Andrew Grieve commented on CB-1604:
-----------------------------------

Sorry for the poor description. This is not related to exec bridge changes.

I don't want to change the API. The shared connection.js file is already set up to fire online/offline
events based on changes to connection.type:
https://github.com/apache/incubator-cordova-js/blob/master/lib/common/plugin/network.js

iOS is not using this code, except for on start-up. Instead, it is firing online/offline events
from the native side, and directly setting navigator.network.connection.type instead of using
a PluginResult so that the JS can set navigator.connection.type. The bug is that I deprecated
navigator.network.connection in favour of navigator.connection, but iOS's native side is hard-coded
to set navigator.network.connection.type.
                
> natigator.connection not implemented correctly on iOS
> -----------------------------------------------------
>
>                 Key: CB-1604
>                 URL: https://issues.apache.org/jira/browse/CB-1604
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>             Fix For: 2.2.0
>
>
> I broke this when changing Android from using navigator.network.connection -> navigator.connection.
iOS currently sets navigator.network.connection and fires online/offline events directly instead
of returning multiple getConnectionInfo() callbacks like Android does. 
> The fix here is to change CDVConnection.m to act the same as Android, and just return
a new getConnectionInfo PluginResult when the connection changes.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message