Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of fil@adobe.com designates
 64.18.1.187 as permitted sender)
From: Filip Maj <fil@adobe.com>
To: "callback-dev@incubator.apache.org" <callback-dev@incubator.apache.org>
Date: Tue, 4 Sep 2012 10:52:13 -0700
Subject: Re: [jira] [Created] (CB-1368) Move navigator.connection.network
 interface to navigator.network and make navigator.onLine be based off of
 network type.
Thread-Topic: [jira] [Created] (CB-1368) Move navigator.connection.network
 interface to navigator.network and make navigator.onLine be based off of
 network type.
Thread-Index: Ac2Kxf1A5+8rUA9JSrOrEAptFze6Nw==
Message-ID: <CC6B8DBF.CBBA%fil@adobe.com>
In-Reply-To: <223679219.33030.1346771768478.JavaMail.jiratomcat@arcas>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.3.120616
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

I don't want to trash an API after one point revision - we need to
deprecate it (current policy is 6 months) first :s

On 9/4/12 8:16 AM, "Andrew Grieve (JIRA)" <jira@apache.org> wrote:

>Andrew Grieve created CB-1368:
>---------------------------------
>
>             Summary: Move navigator.connection.network interface to
>navigator.network and make navigator.onLine be based off of network type.
>                 Key: CB-1368
>                 URL: https://issues.apache.org/jira/browse/CB-1368
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: CordovaJS
>            Reporter: Andrew Grieve
>            Assignee: Andrew Grieve
>            Priority: Minor
>             Fix For: 2.2.0
>
>
>According to: http://www.w3.org/TR/netinfo-api/
>navigator.connection.network should actually be navigator.network.
>
>The difficulty before was figuring out how to clobber navigator's own
>properties with our own, but the following code can be used to achieve
>this:
>
>function ClassWithNavigatorAsPrototype() {}
>ClassWithNavigatorAsPrototype.prototype =3D navigator;
>var newNavigator =3D new ClassWithNavigatorAsPrototype();
>
>This also allows us to set a consistent onLine property:
>
>newNavigator.__defineGetter__('onLine', function() {
>    return this.network.type !=3D 'none';
>});
>
>
>
>--
>This message is automatically generated by JIRA.
>If you think it was sent incorrectly, please contact your JIRA
>administrators
>For more information on JIRA, see: http://www.atlassian.com/software/jira