incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Andrew Grieve (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1387) Splash screens broken due to error in iPad detection code
Date Fri, 07 Sep 2012 16:40:08 GMT

    [ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450769#comment-13450769
] 

Andrew Grieve commented on CB-1387:
-----------------------------------

When did you add this macro? I think it should be namespaced since it appears in a public
header. e.g. CDV_IsIPad()
                
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
>                 Key: CB-1387
>                 URL: https://issues.apache.org/jira/browse/CB-1387
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0
>            Reporter: Tom Clarkson
>            Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a
macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from
finding the correct images.
> The issue appears to be load order -  #ifdef UI_USER_INTERFACE_IDIOM returns false in
CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message