incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Patrick Mueller (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1494) Supports running server behind a proxy, such as Heroku Cedar
Date Mon, 17 Sep 2012 21:59:07 GMT

    [ https://issues.apache.org/jira/browse/CB-1494?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13457394#comment-13457394
] 

Patrick Mueller commented on CB-1494:
-------------------------------------

This commit looks fine to me, in terms of the code.  

I was wondering about "security aspects", but really the ip is only used to further namespacing
of the connection, and to ensure subsequent connections are from the same ip.  I don't think
there are really any further security implications by blindly reading/writing the xff header
value.  

Although, I'm wondering about places we dump the ip address into HTML to being with - like
in the remote panel.  Can someone check that?

Also note that it wasn't immediately clear to me that the XFF header can actually be a set
of IP addresses, not just one.  See: http://rod.vagg.org/2011/07/wrangling-the-x-forwarded-for-header/

Again, I don't think this impacts anything, as it's a namespacing deal, primarily, though
it does show up in the UI in places.

Should we add something to the doc?  I'm thinking a quick mention that we support XFF should
be good enough.
                
> Supports running server behind a proxy, such as Heroku Cedar
> ------------------------------------------------------------
>
>                 Key: CB-1494
>                 URL: https://issues.apache.org/jira/browse/CB-1494
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: weinre
>            Reporter: Patrick Mueller
>            Assignee: Patrick Mueller
>
> created for https://github.com/apache/incubator-cordova-weinre/pull/10

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message