incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Mocny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1387) Splash screens broken due to error in iPad detection code
Date Fri, 07 Sep 2012 14:04:07 GMT

    [ https://issues.apache.org/jira/browse/CB-1387?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13450642#comment-13450642
] 

Michal Mocny commented on CB-1387:
----------------------------------

https://github.com/apache/incubator-cordova-ios/pull/47 seems to fix the issue (verified via
manual tests, and by not seeing the splash screen error logging any more).

The fix was originally suggested in the patch that added the macro.

Does this affect 2.1 release?
                
> Splash screens broken due to error in iPad detection code
> ---------------------------------------------------------
>
>                 Key: CB-1387
>                 URL: https://issues.apache.org/jira/browse/CB-1387
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: 2.1.0
>            Reporter: Tom Clarkson
>            Assignee: Michal Mocny
>
> The fix for CB-1182 removed the IsIPad function from CDVViewController in favor of a
macro in CDVAvailability. Now IsIPad always returns false, preventing showSplashScreen from
finding the correct images.
> The issue appears to be load order -  #ifdef UI_USER_INTERFACE_IDIOM returns false in
CDVAvailability.h, but works correctly when I copy the same macro into CDVViewController.m.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message