Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A5163D835 for ; Wed, 15 Aug 2012 17:02:38 +0000 (UTC) Received: (qmail 62291 invoked by uid 500); 15 Aug 2012 17:02:38 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 62268 invoked by uid 500); 15 Aug 2012 17:02:38 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 62258 invoked by uid 99); 15 Aug 2012 17:02:38 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Aug 2012 17:02:38 +0000 X-ASF-Spam-Status: No, hits=1.5 required=5.0 tests=HTML_MESSAGE,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (athena.apache.org: domain of mikeywbrooks@gmail.com designates 209.85.212.171 as permitted sender) Received: from [209.85.212.171] (HELO mail-wi0-f171.google.com) (209.85.212.171) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 15 Aug 2012 17:02:33 +0000 Received: by wibhq4 with SMTP id hq4so4524246wib.0 for ; Wed, 15 Aug 2012 10:02:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:content-type; bh=boISXioRTIOok6aRVFlALGEnRbvf154Fc4gBHTSkh0Q=; b=aBikvAd/U/Ai30aivIk9mwJirKDD5o+sjvufhuddqpmFt0+YdGLfbg0S0adABZHFAT PWh670/k+EnLcJT9MGSPhpEoy+k1RqOI9W+0iwDvWnR26SyiT+iKLnQh3JdmiuzRYkf0 L7GANp5Va/6wTnjC99AlZhhE9KC5RGcaux2WujikmlWrILHfBwb/WV75/ZIjfRdC31LB IppLYluPdiPdsNgfU798HLe03aAb411GVRnonEhS+QwnBd44d2pIPcaYgGCYV4FKVJXI 3BIlD85EIUtgV94trPelynfIUFJ75n96uo306TicJ9reL+5yErcZaytPy/4VfG9ertrX W78A== MIME-Version: 1.0 Received: by 10.180.82.164 with SMTP id j4mr38399360wiy.18.1345050132611; Wed, 15 Aug 2012 10:02:12 -0700 (PDT) Sender: mikeywbrooks@gmail.com Received: by 10.194.16.230 with HTTP; Wed, 15 Aug 2012 10:02:12 -0700 (PDT) In-Reply-To: References: Date: Wed, 15 Aug 2012 12:02:12 -0500 X-Google-Sender-Auth: QWFDRqrL0kcj1HIN8aJayXV7pPA Message-ID: Subject: Re: [DISCUSS] A plea for sanity in tests From: Michael Brooks To: callback-dev@incubator.apache.org Content-Type: multipart/alternative; boundary=f46d04428d965c023c04c750e304 X-Virus-Checked: Checked by ClamAV on apache.org --f46d04428d965c023c04c750e304 Content-Type: text/plain; charset=ISO-8859-1 > > *Lengthy Tests:* Soon, each API will be pulled out into it's own repository, which means the tests be included with the appropriate API. This should help address your the lengthy test issue, because developing on the File API will be 100% isolated from the other APIs. I think it's good practice to separate distinct features into their own file (and describe function). *Code Quality:* IMHO, test case code should focus more on readability and clarity, than optimization. For Apache Cordova, our code quality is often led by example instead of formalizing syntax format. Jesse, I do like your example code more. Michael On Tue, Aug 14, 2012 at 7:35 PM, Brian LeRoux wrote: > Can we just split the tests for a specific API surface area, eg File, > to a folder of tests per method? That should help some but I'm not > sure if Jasmine is 'run subset of tests' friendly. > > If it isn't we should... > > make it so. > > > > On Tue, Aug 14, 2012 at 5:01 PM, Patrick Mueller > wrote: > > On Tue, Aug 14, 2012 at 6:47 PM, Jesse wrote: > > > >> The Mobile Spec File tests in jasmine contains some 3500+ lines of JS > code. > >> > >> *Lengthy Tests:* > >> > > > > +1 > > > > > >> *Code Quality:* > >> > > > > +1 > > > > -- > > Patrick Mueller > > http://muellerware.org > --f46d04428d965c023c04c750e304--