Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Date: Mon, 27 Aug 2012 11:07:07 +1100 (NCT)
From: "Brion Vibber (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: <556741267.279.1346026027817.JavaMail.jiratomcat@arcas>
In-Reply-To: 
 <1829511484.15023.1335909049798.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Comment Edited] (CB-622) FileTransfer interface should
 provide progress monitoring
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-622?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13442230#comment-13442230 ] 

Brion Vibber edited comment on CB-622 at 8/27/12 11:05 AM:
-----------------------------------------------------------

Updated Android and JS branches here:
https://github.com/wikimedia/incubator-cordova-android/commits/filetransfer-work
https://github.com/wikimedia/incubator-cordova-js/commits/filetransfer-work
(fixed URLs)

I've squashed, rebased, and fixed whitespace on the original commits and made some updates based on feedback above:
* HashMap -> HashSet
* move AbortException to class level
* use Content-Length header in download when possible

Note that since my earlier branch, another parameter has been added to FileTransfer.upload's exec() call -- this rebase adds the new object id after it (headers).

I haven't tested these latest updates, but they compile. ;) When it passes inspection and all works right, I can make a clean squashed version that's ready to merge.

                
      was (Author: brion):
    Updated Android and JS branches here:
https://github.com/brion/incubator-cordova-android/commits/filetransfer-work
https://github.com/brion/incubator-cordova-js/commits/filetransfer-work

I've squashed, rebased, and fixed whitespace on the original commits and made some updates based on feedback above:
* HashMap -> HashSet
* move AbortException to class level
* use Content-Length header in download when possible

Note that since my earlier branch, another parameter has been added to FileTransfer.upload's exec() call -- this rebase adds the new object id after it (headers).

I haven't tested these latest updates, but they compile. ;) When it passes inspection and all works right, I can make a clean squashed version that's ready to merge.

                  
> FileTransfer interface should provide progress monitoring
> ---------------------------------------------------------
>
>                 Key: CB-622
>                 URL: https://issues.apache.org/jira/browse/CB-622
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android, BlackBerry, iOS, WP7
>    Affects Versions: 1.7.0
>         Environment: Checked docs for iOS and Android, and in general.
>            Reporter: Brion Vibber
>            Assignee: Andrew Grieve
>            Priority: Minor
>              Labels: FileTransfer, file
>
> The FileTransfer upload and download interface seems to provide no way to monitor progress of the upload/download, other than waiting for the entire transfer to complete or fail.
> Being able to pass another callback for progress monitoring could be a useful interface, this might get called with a byte count or something.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira