Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C4B70D63A for ; Tue, 7 Aug 2012 18:47:10 +0000 (UTC) Received: (qmail 40660 invoked by uid 500); 7 Aug 2012 18:47:10 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 40637 invoked by uid 500); 7 Aug 2012 18:47:10 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 40627 invoked by uid 99); 7 Aug 2012 18:47:10 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 07 Aug 2012 18:47:10 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 4AD571C4DB; Tue, 7 Aug 2012 18:47:10 +0000 (UTC) From: khawkins To: callback-dev@incubator.apache.org Subject: incubator-cordova-ios pull request: Setting the view controller's view size... Content-Type: text/plain Message-Id: <20120807184710.4AD571C4DB@tyr.zones.apache.org> Date: Tue, 7 Aug 2012 18:47:10 +0000 (UTC) GitHub user khawkins opened a pull request: https://github.com/apache/incubator-cordova-ios/pull/40 Setting the view controller's view size in viewWillAppear. Starting in iOS 4, the recommended way for managing views and view controllers with respect to a `UIWindow` instance is through UIWindow's `rootViewController` property, as opposed to the previous method of adding the view via `addSubview`. Updated the inheriting view controllers and app delegates to follow the recommended pattern. **Note:** This also requires moving the code that sets the default view's frame size to the view controller's `viewWillAppear` method. This code is managed in the consuming app's view controller (as opposed to `CDVViewController`), in the interests of Cordova modularity in developers' apps. You can merge this pull request into a Git repository by running: $ git pull https://github.com/khawkins/incubator-cordova-ios CB-1204 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-cordova-ios/pull/40.patch ---- commit fc70ab134052a1242bd0f2b60062c12881ef14c0 Author: Kevin Hawkins Date: 2012-08-07T11:31:30-07:00 Setting the view controller's view size in viewWillAppear. Starting in iOS 4, the recommended way for managing views and view controllers with respect to a `UIWindow` instance is through UIWindow's `rootViewController` property, as opposed to the previous method of adding the view via `addSubview`. Updated the inheriting view controllers and app delegates to follow the recommended pattern. **Note:** This also requires moving the code that sets the default view's frame size to the view controller's `viewWillAppear` method. This code is managed in the consuming app's view controller (as opposed to `CDVViewController`), in the interests of Cordova modularity in developers' apps. ----