Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Date: Wed, 15 Aug 2012 10:13:38 +1100 (NCT)
From: "Patrick Mueller (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: <1373984448.10399.1344986018144.JavaMail.jiratomcat@arcas>
In-Reply-To: <887040664.7917.1344960278441.JavaMail.jiratomcat@arcas>
Subject: [jira] [Commented] (CB-1234) Console should queue log messages if
 not connected
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434619#comment-13434619 ] 

Patrick Mueller commented on CB-1234:
-------------------------------------

I like the thought of being able to keep the environment as clean as possible.  eg, `jQuery.noConflict()`.  But I can hold my nose.

So, I'm happy with "we always whack the console", per your patch.

Looking at the current usage of `useRemote()` - yeah, fits with your patch.

One thing that does change with your patch is timing; window.console is whacked fairly early.  With the old code it was after a connection.  So, even if some other code whacked window.console (*cough* Cordova/iOS *cough*), you had a good chance that weinre would win.

Any chance you can try your patch with Cordova iOS, with weinre before and after the cordova.js file?


> Console should queue log messages if not connected
> --------------------------------------------------
>
>                 Key: CB-1234
>                 URL: https://issues.apache.org/jira/browse/CB-1234
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: weinre
>    Affects Versions: 2.0.0
>            Reporter: Matt Johnson
>            Assignee: Patrick Mueller
>
> Console log messages (log, debug, error, info, warn) from the target may be lost if they are executed on the device before the remote connection is fully complete.  These should be queued up if there is no remote connection (and dequeued when one is acquired) so all log messages are retained.
> I have a pull request at https://github.com/apache/incubator-cordova-weinre/pull/8 that does this as well as turns the Console into a passthru so that all calls to Console still act on the OriginalConsole as well as the RemoteConsole so that the target behavior with weinre is unchanged.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira