incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Simon MacDonald <simon.macdon...@gmail.com>
Subject Re: Android version support level in Cordova 2.0.0?
Date Mon, 13 Aug 2012 17:32:40 GMT
On Mon, Aug 13, 2012 at 12:16 PM, Joe Bowser <bowserj@gmail.com> wrote:
> On Mon, Aug 13, 2012 at 7:12 AM, Andrew Grieve <agrieve@chromium.org> wrote:
>> In my playing with Android, I've had some issues with this as well. Here's
>> what I've found:
>>
>>
>> In the template AndroidManifest, it specifies version level 8 (should this
>> be 7 then?):
>>
>
> It should be 7, picking 8 is really weird since it excludes Android 2.1

Fixed it and pushed change.

>> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=blob;f=bin/templates/project/AndroidManifest.xml;h=9e9abcdf9273a5d5c38c71481e8de71761c617e2;hb=HEAD#l60
>>
>> The framework AndroidManifest specifies version 2 (this should certainly
>> match the template's value):
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=blob;f=framework/AndroidManifest.xml;h=92f66f449b31fefd8edd969d1cc4bc363a5d709f;hb=HEAD#l67
>>
>
> This is very old, and most likely should be ignored. We don't support
> any Android versions below 2.1 and there would be some weird runtime
> errors if you were to run PhoneGap on a T-Mobile G1.

Fixed it and pushed change.

>> Once updating the value in the framework's manifest, Eclipse complains
>> about one of CordovaWebView's constructors calling a super-constructor that
>> is new in API version 11 (privateBrowsing).
>>
>> https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=blob;f=framework/src/org/apache/cordova/CordovaWebView.java;h=f7f2be6f7bd87ed89abe44dc99dca9e2bbe4c384;hb=HEAD#l161
>>
>> Adding @TargetSdk(11) fixes this warning. Is that the correct fix though?
>>
>
> That is correct.  We don't care about that warning, since we always
> target the latest SDK, and older SDKs won't be running newer
> constructors.  We also assume that anyone who is turning on private
> browsing on a PhoneGap application knows what they're doing, and that
> since it's open source, and this requires source modification to do
> this, they get to keep both pieces. :)
>
> That being said, we make sure that CORE phonegap features work.  We
> can't vouch for plugins, and I find that we're on this constant
> slippery slope with plugins and other Java dev happening in the
> Android version that we should find ways to work around.

Agree 100% with Joe, always build with the latest SDK. It is an
involatile rule along the lines of "always bet on black".

Simon Mac Donald
http://hi.im/simonmacdonald

Mime
View raw message