incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: js commit: [WINDOWS8] Linting issues
Date Mon, 27 Aug 2012 21:19:17 GMT
I fixed a lot of the linting issues, however there are still numerous
extra/missing semicolon issues.
In the meantime, if these bug you, try removing this line from your
Jakefile:
packager.generate("windows8",commitId);

... Otherwise, your whining will fall on deaf ears.


On Mon, Aug 27, 2012 at 2:06 PM, Filip Maj <fil@adobe.com> wrote:

> Thx jesse :D
>
> On 8/27/12 2:04 PM, "purplecabbage@apache.org" <purplecabbage@apache.org>
> wrote:
>
> >Updated Branches:
> >  refs/heads/master 660a77244 -> 8878baedb
> >
> >
> >[WINDOWS8] Linting issues
> >
> >
> >Project: http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/repo
> >Commit:
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/commit/8878bae
> >d
> >Tree:
> >http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/tree/8878baed
> >Diff:
> >http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/diff/8878baed
> >
> >Branch: refs/heads/master
> >Commit: 8878baedb767253539a39dfe98b9ed8682df6526
> >Parents: 660a772
> >Author: purplecabbage <purplecabbage@gmail.com>
> >Authored: Mon Aug 27 14:04:12 2012 -0700
> >Committer: purplecabbage <purplecabbage@gmail.com>
> >Committed: Mon Aug 27 14:04:12 2012 -0700
> >
> >----------------------------------------------------------------------
> > lib/windows8/plugin/windows8/AccelerometerProxy.js |    1 +
> > lib/windows8/plugin/windows8/CameraProxy.js        |   22 +++++++-------
> > lib/windows8/plugin/windows8/CaptureProxy.js       |    4 ++-
> > lib/windows8/plugin/windows8/CompassProxy.js       |    1 +
> > lib/windows8/plugin/windows8/FileProxy.js          |    2 +
> > lib/windows8/plugin/windows8/MediaFile.js          |    2 +
> > lib/windows8/plugin/windows8/MediaProxy.js         |    5 +++-
> > lib/windows8/plugin/windows8/NetworkStatusProxy.js |    1 -
> > lib/windows8/plugin/windows8/NotificationProxy.js  |    2 +
> > lib/windows8/plugin/windows8/geolocation.js        |    2 +
> > 10 files changed, 28 insertions(+), 14 deletions(-)
> >----------------------------------------------------------------------
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/AccelerometerProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/AccelerometerProxy.js
> >b/lib/windows8/plugin/windows8/AccelerometerProxy.js
> >index 84199df..ba2aa0c 100644
> >--- a/lib/windows8/plugin/windows8/AccelerometerProxy.js
> >+++ b/lib/windows8/plugin/windows8/AccelerometerProxy.js
> >@@ -1,4 +1,5 @@
> > /*global Windows:true */
> >+
> > var cordova = require('cordova'),
> >     Acceleration = require('cordova/plugin/Acceleration');
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/CameraProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/CameraProxy.js
> >b/lib/windows8/plugin/windows8/CameraProxy.js
> >index f4c91c3..7f0f5b0 100644
> >--- a/lib/windows8/plugin/windows8/CameraProxy.js
> >+++ b/lib/windows8/plugin/windows8/CameraProxy.js
> >@@ -2,8 +2,9 @@
> >
> >
> > var cordova = require('cordova'),
> >-    Camera = require('cordova/plugin/CameraConstants');
> >-
> >+    Camera = require('cordova/plugin/CameraConstants'),
> >+    FileEntry = require('cordova/plugin/FileEntry'),
> >+    FileError = require('cordova/plugin/FileError');
> >
> > module.exports = {
> >
> >@@ -31,8 +32,12 @@ module.exports = {
> >         var saveToPhotoAlbum = args[9];
> >
> >
> >-        var package = Windows.ApplicationModel.Package.current;
> >-        var packageId = package.installedLocation;
> >+        var pkg = Windows.ApplicationModel.Package.current;
> >+        var packageId = pkg.installedLocation;
> >+
> >+        var fail = function (fileError) {
> >+            errorCallback("FileError, code:" + fileError.code);
> >+        };
> >
> >         // resize method :)
> >         var resizeImage = function (file) {
> >@@ -45,8 +50,7 @@ module.exports = {
> >             var imgObj = new Image();
> >             var success = function (fileEntry) {
> >                 var successCB = function (filePhoto) {
> >-                    var filePhoto = filePhoto,
> >-                        fileType = file.contentType,
> >+                    var fileType = file.contentType,
> >                         reader = new FileReader();
> >                     reader.onloadend = function () {
> >                         var image = new Image();
> >@@ -108,8 +112,7 @@ module.exports = {
> >             var imgObj = new Image();
> >             var success = function (fileEntry) {
> >                 var successCB = function (filePhoto) {
> >-                    var filePhoto = filePhoto,
> >-                        fileType = file.contentType,
> >+                    var fileType = file.contentType,
> >                         reader = new FileReader();
> >                     reader.onloadend = function () {
> >                         var image = new Image();
> >@@ -145,9 +148,6 @@ module.exports = {
> >                 fileEntry.file(successCB, failCB);
> >             }
> >
> >-            var fail = function (fileError) {
> >-                errorCallback("FileError, code:" + fileError.code);
> >-            }
> >
> >Windows.Storage.StorageFolder.getFolderFromPathAsync(packageId.path).done(
> >function (storageFolder) {
> >                 file.copyAsync(storageFolder, file.name,
> >Windows.Storage.NameCollisionOption.replaceExisting).then(function
> >(storageFile) {
> >                     success(new FileEntry(storageFile.name,
> >storageFile.path));
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/CaptureProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/CaptureProxy.js
> >b/lib/windows8/plugin/windows8/CaptureProxy.js
> >index 83a9ee4..cc80b56 100644
> >--- a/lib/windows8/plugin/windows8/CaptureProxy.js
> >+++ b/lib/windows8/plugin/windows8/CaptureProxy.js
> >@@ -1,4 +1,6 @@
> >-???var MediaFile = require('cordova/plugin/MediaFile');
> >+???/*global Windows:true */
> >+
> >+var MediaFile = require('cordova/plugin/MediaFile');
> > var CaptureError = require('cordova/plugin/CaptureError');
> > var CaptureAudioOptions = require('cordova/plugin/CaptureAudioOptions');
> > var CaptureImageOptions = require('cordova/plugin/CaptureImageOptions');
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/CompassProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/CompassProxy.js
> >b/lib/windows8/plugin/windows8/CompassProxy.js
> >index 9be8ecd..8b80415 100644
> >--- a/lib/windows8/plugin/windows8/CompassProxy.js
> >+++ b/lib/windows8/plugin/windows8/CompassProxy.js
> >@@ -1,4 +1,5 @@
> > /*global Windows:true */
> >+
> > var cordova = require('cordova'),
> >     CompassHeading = require('cordova/plugin/CompassHeading');
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/FileProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/FileProxy.js
> >b/lib/windows8/plugin/windows8/FileProxy.js
> >index 9c2dade..13cbbfa 100644
> >--- a/lib/windows8/plugin/windows8/FileProxy.js
> >+++ b/lib/windows8/plugin/windows8/FileProxy.js
> >@@ -1,3 +1,5 @@
> >+/*global Windows:true */
> >+
> > var cordova = require('cordova');
> >
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/MediaFile.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/MediaFile.js
> >b/lib/windows8/plugin/windows8/MediaFile.js
> >index aa828a1..0fcf7fb 100644
> >--- a/lib/windows8/plugin/windows8/MediaFile.js
> >+++ b/lib/windows8/plugin/windows8/MediaFile.js
> >@@ -1,3 +1,5 @@
> >+/*global Windows:true */
> >+
> > var MediaFileData = require('cordova/plugin/MediaFileData');
> > var CaptureError = require('cordova/plugin/CaptureError');
> >
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/MediaProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/MediaProxy.js
> >b/lib/windows8/plugin/windows8/MediaProxy.js
> >index 39de090..3f36c73 100644
> >--- a/lib/windows8/plugin/windows8/MediaProxy.js
> >+++ b/lib/windows8/plugin/windows8/MediaProxy.js
> >@@ -1,4 +1,7 @@
> >-var cordova = require('cordova');
> >+/*global Windows:true */
> >+
> >+var cordova = require('cordova'),
> >+    Media = require('cordova/plugn/Media');
> >
> > module.exports = {
> >     mediaCaptureMrg:null,
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/NetworkStatusProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/NetworkStatusProxy.js
> >b/lib/windows8/plugin/windows8/NetworkStatusProxy.js
> >index 6916d0a..e1f507b 100644
> >--- a/lib/windows8/plugin/windows8/NetworkStatusProxy.js
> >+++ b/lib/windows8/plugin/windows8/NetworkStatusProxy.js
> >@@ -1,4 +1,3 @@
> >-
> > /*global Windows:true */
> >
> > var cordova = require('cordova');
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/NotificationProxy.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/NotificationProxy.js
> >b/lib/windows8/plugin/windows8/NotificationProxy.js
> >index 728fe86..554f918 100644
> >--- a/lib/windows8/plugin/windows8/NotificationProxy.js
> >+++ b/lib/windows8/plugin/windows8/NotificationProxy.js
> >@@ -1,3 +1,5 @@
> >+/*global Windows:true */
> >+
> > var cordova = require('cordova');
> >
> > module.exports = {
> >
> >
> http://git-wip-us.apache.org/repos/asf/incubator-cordova-js/blob/8878baed/
> >lib/windows8/plugin/windows8/geolocation.js
> >----------------------------------------------------------------------
> >diff --git a/lib/windows8/plugin/windows8/geolocation.js
> >b/lib/windows8/plugin/windows8/geolocation.js
> >index 434dcf9..c9d2f34 100644
> >--- a/lib/windows8/plugin/windows8/geolocation.js
> >+++ b/lib/windows8/plugin/windows8/geolocation.js
> >@@ -1,3 +1,5 @@
> >+/*global Windows:true */
> >+
> > var Position = require('cordova/plugin/Position'),
> >     PositionError = require('cordova/plugin/PositionError');
> >
> >
>
>


-- 
@purplecabbage
risingj.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message