incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: Code Prettifiers
Date Mon, 27 Aug 2012 18:18:38 GMT
iOS actually has an issue in there, filed by me in May:
https://issues.apache.org/jira/browse/CB-625

re: the uncrustify command line tool (GPL)
https://github.com/bengardner/uncrustify
http://uncrustify.sourceforge.net/ pretty much cross-platform

On Mon, Aug 27, 2012 at 11:07 AM, Becky Gibson <gibson.becky@gmail.com> wrote:
> So, as a committer whose code isn't always as clean as could be, I'm all in
> favor of tools that help me to fix my bad habits. I like the hint feature
> of cordova-js.    I'll at least go back to the style guide and make sure my
> xcode settings are correct as I recently re-installed.  However, if you
> work on more than one project (open source or otherwise) sometimes it is
> hard to keep all of the coding "rules" straight between the different
> groups.
>
> -becky
>
>
> On Mon, Aug 27, 2012 at 1:23 PM, Jesse <purplecabbage@gmail.com> wrote:
>
>> Focus on being a contributor and not an arbiter.
>>
>> If these problems do indeed become problems, then we will deal with them,
>> however, I don't think we have issues currently, and even if we do, they
>> are minor IMHO.
>>
>> + everything that Michael said, although, I would not shame anyone, and
>> would simply weigh the value of the contribution with the work required to
>> appease critical peers, before deciding to pull or push back.
>>
>>
>>
>>
>>
>> On Mon, Aug 27, 2012 at 10:12 AM, Patrick Mueller <pmuellr@gmail.com>
>> wrote:
>>
>> > On Mon, Aug 27, 2012 at 10:33 AM, Andrew Grieve <agrieve@chromium.org
>> > >wrote:
>> >
>> > > ...
>> > >
>> > > One thing we may have to do is ask a contributor to enable the git
>> hooks.
>> > > AFAIK there is no way to enable shared git hooks for a project by
>> > default,
>> > > so what we'd have is a directory called "hooks" and you'd need to
>> create
>> > a
>> > > symlink for it into your .git/ directory.
>> > >
>> >
>> > Another option is to do this in some sort of continuous build
>> environment.
>> >  Where would the "style enforcer" post it's messages though?  Open bugs?
>> >
>> > If no one objects, then I'll pursue this today/tomorrow. My plan is to
>> > > start with whitespace (sed or awk), get that working, and then see what
>> > > x-platform open-source formatters exist out there.
>> > >
>> >
>> > Presumably these hooks need to be portable to *nix and Windows (where mac
>> > == *nix).  Could we do them in node, without having to shell out to
>> > command-line tools?  Or maybe have the hooks be js that shell out to
>> > cmd-line tools you'd need to have installed.
>> >
>> > --
>> > Patrick Mueller
>> > http://muellerware.org
>> >
>>
>>
>>
>> --
>> @purplecabbage
>> risingj.com
>>

Mime
View raw message