incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Andrew Grieve <agri...@chromium.org>
Subject Re: incubator-cordova-ios pull request: Fix init with empty string
Date Fri, 03 Aug 2012 15:25:26 GMT
Great first change Mike! I'll patch this in.


On Fri, Aug 3, 2012 at 11:15 AM, mmocny <git@git.apache.org> wrote:

> GitHub user mmocny opened a pull request:
>
>     https://github.com/apache/incubator-cordova-ios/pull/39
>
>     Fix init with empty string
>
>     xcode 4.4 is giving me a warning that these are equivalent and should
> be replaced with the simpler initialization.
>
>     Trivial patch intended to get my feet wet with pull requests :)
>
> You can merge this pull request into a Git repository by running:
>
>     $ git pull https://github.com/mmocny/incubator-cordova-iosfix_init_with_empty_string
>
> Alternatively you can review and apply these changes as the patch at:
>
>     https://github.com/apache/incubator-cordova-ios/pull/39.patch
>
> ----
> commit fe006aea3cd4c1f8b07cb265e70a636239f850c5
> Author: Andrew Grieve <agrieve@chromium.org>
> Date:   2012-08-03T07:10:19-07:00
>
>     Fix typo in Makefile.
>
>     within an if block: @mv -> mv
>
> commit 469061dc58548869d27cfce572a2c44da181c3de
> Author: Michal Mocny <mmocny@gmail.com>
> Date:   2012-08-03T08:05:20-07:00
>
>     Fixing NSString initWithString with empty string to just use empty
> string.
>
> ----
>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message