incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Michal Mocny (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1182) iOS 6 - Autorotation changes
Date Wed, 29 Aug 2012 15:12:07 GMT

    [ https://issues.apache.org/jira/browse/CB-1182?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13444125#comment-13444125
] 

Michal Mocny commented on CB-1182:
----------------------------------

Fix here: https://github.com/apache/incubator-cordova-ios/pull/45

(copying comments from the pull request here):

* The IsIPad macro came from an earlier revision of this patch that needed to use it. Its
not used any more so can be removed, but I thought it was worth leaving in.
* I understand that changes to the AppDelegate template are best avoided, but there is no
way around it for this fix. Some of the changes could be avoided by not removing the ViewController::supportedOrientations
array, but if we are making changes anyway, I think its best to clean this up right.
* I didn't make changes to the CordovaTests project's AppDelegate. That app delegate has diverged
from the original template already -- so, what is the correct process here? (Did I miss any
other changes needed when touching AppDelegate? Any other process?)
* The JS calls we make are not efficient (we make 4-8 js evaluations per rotation). There
is also a w3c proposal for screen orientation (http://www.w3.org/TR/screen-orientation/#widl-Screen-onorientationchange)
though it is not perfect. I plan to reach out to the mozilla dev who submitted that to raise
some missing functionality with the proposal, but perhaps I'll post to ML to discuss what
a good spec would have.
                
> iOS 6 - Autorotation changes
> ----------------------------
>
>                 Key: CB-1182
>                 URL: https://issues.apache.org/jira/browse/CB-1182
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: iOS
>    Affects Versions: Master
>            Reporter: Shazron Abdullah
>            Assignee: Michal Mocny
>              Labels: ios6
>             Fix For: 2.1.0
>
>
> From Michael SBCERA: 
> Autorotation is changing in iOS 6. In iOS 6, the shouldAutorotateToInterfaceOrientation:
method of UIViewController is deprecated. In its place, you should use the supportedInterfaceOrientations
and shouldAutorotate methods. Read more at http://9to5mac.com/2012/06/25/apple-pushes-ios-6-0-update-to-devs/#tumhkqaj5kDKYOC3.99


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira

Mime
View raw message