incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Steren <...@git.apache.org>
Subject incubator-cordova-android pull request: Play <video> tags from the Webview ...
Date Thu, 16 Aug 2012 10:38:23 GMT
GitHub user Steren opened a pull request:

    https://github.com/apache/incubator-cordova-android/pull/43

    Play <video> tags from the Webview in a Fullscreen video player.

    Code from the Froyo Android Browser was adapted to support <video> elements in Cordova.
The WebView creates a "CustomView" (a video player) that is displayed fullscreen.
    It uses API level 7, work has to be done to support lower version.
    
    Tested on Android 2.2: works
    Tested on Android 4.1: doesn't work. It seems videos are handled differently (without
the use of "Custom views"). To make video playing work on Android 4, add the android:hardwareAccelerated="true"
attribute to the main activity of the AndroidManifest.
    
    I'm available for comments and questions. I can sign the Apache CLA if you decide to accept
the pull request.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/joshfire/incubator-cordova-android master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-cordova-android/pull/43.patch

----
commit 06aafc96c9fd55a4d98dd032710048ed211ac49e
Author: Steren Giannini <steren.giannini@gmail.com>
Date:   2012-08-14T09:13:35-07:00

    Play <video> tags from the Webview in a Fullscreen video player.
    Code from the Froyo Android Browser was adapted to support <video> elements in Cordova.
The WebView creates a "CustomView" (a video player) that is displayed fullscreen.
    It uses API level 7, work has to be done to support lower version.
    
    Tested on Androdi 2.2: works
    Tested on Android 4.1: doesn't work. It seems videos are handled differently (without
the use of "Custom views"). To make video playing work on Android 4, add the android:hardwareAccelerated="true"
attribute to the main activity of the AndroidManifest.

----


Mime
View raw message