incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Matt Johnson (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1234) Console should queue log messages if not connected
Date Tue, 14 Aug 2012 19:00:39 GMT

    [ https://issues.apache.org/jira/browse/CB-1234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13434387#comment-13434387
] 

Matt Johnson commented on CB-1234:
----------------------------------

If the default behavior is to act as a passthru and send log messages to both and the two
sendTo methods turn on/off the two destinations, what's the point of switching the console
in useRemote?  

Isn't the semantic value of useRemote then just that the remote connection is ready and we
can send stuff to it?  

If the console is swapped in useRemote as it was before, then we don't have a reliable method
of intercepting the log messages until useRemote(true) is called which happens too late in
many cases.
                
> Console should queue log messages if not connected
> --------------------------------------------------
>
>                 Key: CB-1234
>                 URL: https://issues.apache.org/jira/browse/CB-1234
>             Project: Apache Cordova
>          Issue Type: New Feature
>          Components: weinre
>    Affects Versions: 2.0.0
>            Reporter: Matt Johnson
>            Assignee: Patrick Mueller
>
> Console log messages (log, debug, error, info, warn) from the target may be lost if they
are executed on the device before the remote connection is fully complete.  These should be
queued up if there is no remote connection (and dequeued when one is acquired) so all log
messages are retained.
> I have a pull request at https://github.com/apache/incubator-cordova-weinre/pull/8 that
does this as well as turns the Console into a passthru so that all calls to Console still
act on the OriginalConsole as well as the RemoteConsole so that the target behavior with weinre
is unchanged.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message