Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 7F340D71B for ; Thu, 12 Jul 2012 12:05:18 +0000 (UTC) Received: (qmail 99390 invoked by uid 500); 12 Jul 2012 12:05:18 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 98166 invoked by uid 500); 12 Jul 2012 12:05:16 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 98103 invoked by uid 99); 12 Jul 2012 12:05:15 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 12 Jul 2012 12:05:15 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id A50AA13478; Thu, 12 Jul 2012 12:05:14 +0000 (UTC) From: Git at Apache To: callback-dev@incubator.apache.org Subject: incubator-cordova-ios pull request: Refactor chooseContact() to retreive co... Content-Type: text/plain Message-Id: <20120712120514.A50AA13478@tyr.zones.apache.org> Date: Thu, 12 Jul 2012 12:05:14 +0000 (UTC) GitHub user mgcrea opened a pull request: https://github.com/apache/incubator-cordova-ios/pull/34 Refactor chooseContact() to retreive contact information instead of just... Breaking API change (returns an object instead of just an int) but really necessary to me as there is no easy way to retreive a contact by ID. Loading the whole addressbook in javascript appeared to have a major performance hit on some device (> 500 contacts). Memory efficiency javascript side is critical to build nice cordova apps. You can merge this pull request into a Git repository by running: $ git pull https://github.com/mgcrea/incubator-cordova-ios patches-cdvcontacts-2 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/incubator-cordova-ios/pull/34.patch ---- commit 1da8ec63fc79aff0b7869a0a37130769cd0ec98d Author: Olivier Louvignes Date: 2012-07-12T05:00:18-07:00 Refactor chooseContact() to retreive contact information instead of just a contactId. ----