incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: [jira] [Commented] (CB-1061) Create "Hello Cordova" Sample Application
Date Wed, 18 Jul 2012 23:53:04 GMT
I have committed changes fixing the classList issue.
Also, I removed the bind method as it implied that there was some scope
issue that needed to be worked around.
I removed the 'report' method, as it was NOT a reusable method and did not
make sense.
( it took a DOM element ID as an arg, and yet it 'knew' that the element
had children with css classes of 'pending' and 'complete'.  I believe this
would simply confuse noobs more than it would encourage good practices. )

On Wed, Jul 18, 2012 at 4:45 PM, Filip Maj (JIRA) <jira@apache.org> wrote:

>
>     [
> https://issues.apache.org/jira/browse/CB-1061?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13417858#comment-13417858]
>
> Filip Maj commented on CB-1061:
> -------------------------------
>
> I think the purpose of that was to encourage a nicer, clearer app
> structure. Surely not needed for our simple sample, but I think it's a good
> idea to keep.
>
> Also, re {{classList}}: webOS doesn't support it. According to [
> caniuse.com|http://caniuse.com/classlist], also iOS before 5.0 and
> Android before 3.0 would not support it either. So, definitely need to
> scrap it.
>
> > Create "Hello Cordova" Sample Application
> > -----------------------------------------
> >
> >                 Key: CB-1061
> >                 URL: https://issues.apache.org/jira/browse/CB-1061
> >             Project: Apache Cordova
> >          Issue Type: New Feature
> >    Affects Versions: 2.0.0
> >         Environment: [incubator-cordova-labs] branch: hello-cordova
> >            Reporter: Michael Brooks
> >            Assignee: Michael Brooks
> >             Fix For: 2.0.0
> >
> >
> > Create a "Hello Cordova" sample web application that can be used as the
> default application for all Cordova platforms.
> > Existing work can be found as gists:
> > - https://gist.github.com/2830598
> > - https://gist.github.com/2830156
> > Mailing-list conversation can be found at:
> > - [Markmail "Standard Sample Application"|
> http://markmail.org/search/?q=%22Standard+Sample+Application%22#query:%22Standard%20Sample%20Application%22+page:1+mid:a55vkom5acy4y4up+state:results
> ]
>
> --
> This message is automatically generated by JIRA.
> If you think it was sent incorrectly, please contact your JIRA
> administrators:
> https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
> For more information on JIRA, see: http://www.atlassian.com/software/jira
>
>
>


-- 
@purplecabbage
risingj.com

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message