incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Becky Gibson <gibson.be...@gmail.com>
Subject Update on iOS ARC conversion
Date Tue, 24 Jul 2012 20:23:39 GMT
I think I have the ARC conversion completed.   I can pass all mobile-spec
automated tests on my iPhone 4S and iPad 2 - both running 5.1.1. The
mobile-spec manual tests work, also.  I've also done some testing with my
own files.   There is still some cleanup needed as I commented many things
rather than removing them so people could at least get some idea of the
changes.   Any property that was marked as retain is now strong.   I
generally left the default for local vars as strong.  This is because since
we are still supporting 4.2 we can't use the weak keyword and must use
__unsafe__unretained which looks pretty scary in the code (although maybe
it is a good idea to be reminded of those pointers that will not get set to
nil and may dangle).

I didn't issue a pull request yet but would appreciate it if anyone has
time to give it a look through.  We may want to wait a few more days before
merging but if we want to get this in for 2.1 we should probably do it by
next week.   Also, I should probably update a few plugins to ARC as well -
any suggestions for which ones?   Also, there are two commits in my branch
as I forgot to do a --force on one of my updates.  I guess I can fix that
with git rebase --i but it isn't one of my favorite commands if there are
other methods to squash those together.

The CDVUIViewController,  CDVLocalStorage and CDVFileTransfer had lots of
changes during the last month that I had to merge so if any additional
testing of those would be appreciated.  I don't have very thorough test
files for storage and file transfer.  Contacts has the most changes since
it has to bridge to the core foundation classes.  I did fairly thorough
testing of contacts but it is such a large api it is hard to test
everything.    I didn't attempt to transition JSONKit.* to ARC, it has
the -fno-objc-arc complier flag set.   I modified the app project settings
for ARC in addition to the CordovaLib settings.


thanks,
-becky

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message