incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Joe Bowser (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-913) Refactor Key Press Overrides on Android
Date Thu, 26 Jul 2012 16:51:34 GMT

    [ https://issues.apache.org/jira/browse/CB-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13423221#comment-13423221
] 

Joe Bowser commented on CB-913:
-------------------------------

OK, so we have two ways to solve it, both have their own failings:

1. We fire an event called androidKeyUp and androidKeyDown, and make our users look up the
Android Key Codes.
2. We map the Android keyCodes

I think we should do both. I'm fine with providing a JS file with some constants for GoogleTV
and Xperia Play users in cordova-labs.  I don't want us to try and do any re-assignment/re-mapping
on the native side, since that can be prone to bugs.

Thoughts?
                
> Refactor Key Press Overrides on Android
> ---------------------------------------
>
>                 Key: CB-913
>                 URL: https://issues.apache.org/jira/browse/CB-913
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: Android
>    Affects Versions: 1.8.0
>            Reporter: Joe Bowser
>            Assignee: Joe Bowser
>             Fix For: 2.1.0
>
>
> Currently the Volume Up and Down events are in DroidGap.java.  While this is fine for
the general use case, it would be better if there was a utility class that handled these events.
 This would also allow us to implement the GamePad API for the Google TV events, because Google
in their infinite wisdom chose to re-implement this instead of using the standard keyCodes
for Up, Down, Left and Right.
> This should fix existing bugs on Google TV, as well as make the code neater.  It also
addresses CB-417.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message