incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Git at Apache <...@git.apache.org>
Subject incubator-cordova-ios pull request: Refactor chooseContact() to retreive co...
Date Thu, 12 Jul 2012 12:05:14 GMT
GitHub user mgcrea opened a pull request:

    https://github.com/apache/incubator-cordova-ios/pull/34

    Refactor chooseContact() to retreive contact information instead of just...

    Breaking API change (returns an object instead of just an int) but really necessary to
me as there is no easy way to retreive a contact by ID.
    
    Loading the whole addressbook in javascript appeared to have a major performance hit on
some device (> 500 contacts).
    
    Memory efficiency javascript side is critical to build nice cordova apps.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mgcrea/incubator-cordova-ios patches-cdvcontacts-2

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-cordova-ios/pull/34.patch

----
commit 1da8ec63fc79aff0b7869a0a37130769cd0ec98d
Author: Olivier Louvignes <olivier@mg-crea.com>
Date:   2012-07-12T05:00:18-07:00

    Refactor chooseContact() to retreive contact information instead of just a contactId.

----


Mime
View raw message