incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Git at Apache <>
Subject incubator-cordova-ios pull request: Moretests
Date Fri, 06 Jul 2012 17:19:28 GMT
GitHub user agrieve opened a pull request:


    Again, not sure of the best way to handle this via github. This is the same as my first
pull request, except with one more commit. Should be able to cherry pick the last commit from
here after the first goes through, or just tell me to rebase after the first pull request
finishes up. Please advise if there is a better protocol.

You can merge this pull request into a Git repository by running:

    $ git pull moretests

Alternatively you can review and apply these changes as the patch at:

commit 84353192dadb58aedb3b539825283a9da8c3c48b
Author: Andrew Grieve <>
Date:   2012-07-05T08:23:34-07:00

    Add VERSION file to the resources of CordovaLibApp
    Required so that CDVViewController::cordovaVersion does not return nil.

commit b1ee0c3e8e8d95f5518a8d524926cfd9b3588854
Author: Andrew Grieve <>
Date:   2012-07-05T09:13:27-07:00

    Remove unit test header files and simplify CDVWebViewTest.
    Unit tests are isolated, so there is no need to export their information
    in headers. Removing them simplifies things a bit.
    CDVWebViewTest was using reflection unnecessarily. Simplified it with
    direct selectors.

commit 14592e7418b71d325d4efbd83aff17b2feb2fb82
Author: Andrew Grieve <>
Date:   2012-07-06T06:23:54-07:00

    Adds a dispose method to CDVViewController.
    This method attempts to break retain cycles. We may want to consider
    breaking these cycles using weak references in the future. This function
    will be used by unit tests.

commit 83ce8ae4ae0a8973ddfe8367091adc5241592249
Author: Andrew Grieve <>
Date:   2012-07-06T06:27:52-07:00

    Adds a way for CordovaLibApp to recreate the ViewController.
    This does not change the behaviour of CordovaLibApp when run directly,
    but causes the root ViewController to not be created automatically when
    running the unit tests. The intention here is that unit tests that
    require a full ViewController will use the methods to create it and
    destroy it afterwards.

commit 69eca0c1084f0c65021927a171895ec390313443
Author: Andrew Grieve <>
Date:   2012-07-06T06:30:51-07:00

    Refactor of CDVWebViewTest and partial implementation of CDVLocalStorageTests
    Thes CDVWebViewTest base class will now wait for the WebView to be fully
    loaded before returning a reference to it. It does this by running the
    run loop until a JS variable set at the bottom of index.html reports
    being set.

commit 1504202551de207a8b8b88466133b0b1125d669e
Author: Andrew Grieve <>
Date:   2012-07-06T06:56:36-07:00

    Don't use @autoreleasepool.
    Doing so causes a runtime error in the 4.3 simulator.

commit 7c14ee26164f5b13f69c81474b7214abea2c1f88
Author: Andrew Grieve <>
Date:   2012-07-06T08:15:32-07:00

    Added unit test for CDVLocalStorage::__verifyAndFixDatabaseLocations
    Additional changes:
    * Refactored __verifyAndFixDatabaseLocations into two methods so that it
    can be tested without touching the file system.
    * Added a FakeFileManager for stubbing out the call to fileExistsAtPath


View raw message