incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Shazron Abdullah (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1000) Namespace issue of JSONKit and other external libraries
Date Tue, 03 Jul 2012 23:24:33 GMT

    [ https://issues.apache.org/jira/browse/CB-1000?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13406162#comment-13406162
] 

Shazron Abdullah commented on CB-1000:
--------------------------------------

Ideally yes, but this is less critical I suppose - the runtime behaviour is undefined, which
is a bad thing when two libs add a method with the same name in a class category - you don't
know which method is being called (thus buggy behaviour is harder to trace). This won't be
a problem (generally) if the categories were from the same lib (which you would expect to
have the same behaviour).

We would have to be really complete and reliable, and prefix all category methods here (NSData+Base64
and JSONKit). I'm on vacation this week, but I can tackle this next week. Since this will
be a breaking API change (some plugins do use the Cordova JSONKit), it will definitely go
in 2.0 not 1.9.1 (if we ever decide to do 1.9.1)


                
> Namespace issue of JSONKit and other external libraries
> -------------------------------------------------------
>
>                 Key: CB-1000
>                 URL: https://issues.apache.org/jira/browse/CB-1000
>             Project: Apache Cordova
>          Issue Type: Bug
>    Affects Versions: 1.9.0
>         Environment: iOS
>            Reporter: LOU Yu Hong
>             Fix For: 2.0.0
>
>   Original Estimate: 48h
>  Remaining Estimate: 48h
>
> jk_collectionClassLoadTimeInitialization should also be prefixed
> Other external libraries such as NSData+Base64 can cause duplicating symbols as well

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message