incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kerri Shotts (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (CB-1156) Android app creation is broken in several ways!
Date Sat, 28 Jul 2012 23:13:33 GMT

    [ https://issues.apache.org/jira/browse/CB-1156?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13424455#comment-13424455
] 

Kerri Shotts commented on CB-1156:
----------------------------------

> About the splashScreen, to me you should decide whether it should be bundled or not,
but once the call has been made, just unify every platform as it is the core promise of Cordova.
Also, it is way more easy to comment one-line out that to search the whole web on what&how
to add to make it work.

But here's the thing: not every platform should necessarily be the same in this respect. The
idea is to make the app feel at home natively -- if a platform doesn't always specify a splash
screen, which Android doesn't, why should Cordova? On those platforms that always requires
a platform, yes, it must be there, but if a platform doesn't need it, then you're affecting
at least one side or the other -- someone must either turn it on or off. Furthermore, since
Android is such a diverse and fragmented platform, I would personally think that it would
be more risky to load this by default as it might lead to more crashes and issues. Not supporting
it by default is easier to maintain and ensure that it runs.

> About the indenting, for instance the manifest, where it is not indented the same way
through the file... Just like to keep things clean & readable, does not cost much.

Indenting is a personal preference. I can make Eclipse indent any way I want. Therefore, the
indentation on this file is a minor issue -- you can re-indent it if you prefer another method
of indentation. I have my way -- you have yours. All that I might care about would be consistent
indentation across the project, and honestly, I don't even care about that.

> I don't really understand the point of "the team is not using Eclipse" as it is the default
editor for Android, every example in the docs uses Eclipses screenshots, the getting started
guide ask to install Eclipse... ! Today it is painful to add a project to Eclipse because
of these missing files.

Not everyone uses Eclipse. Just because that's the method the Getting Started guides use doesn't
mean everyone uses it. There's DreamWeaver support too. Or you could do it entirely on the
command line. 

> You should just understand that setting up an Eclipse project is really hard today for
us foreigners (following the guides & installing Eclipse guys). Just thought it was important
and a really easy fix that can save several hours of work for newcomers.

The project created by Cordova is just enough to compile on the command line. Creating a project
in Eclipse is /really/ easy once you have run the create command:

 - Create Android Project (using what the create script just created)
 - Configure the build path and add libs/cordova.jar as an external library.

That's it -- your project is ready to roll. To me, not that difficult, really. Now if you're
referring to building the project entirely in Eclipse from scratch, I agree -- /that/ is painful.
But from the files the create script makes, very easy.

> And for the echo stuff, what would be the benefit of not echo'ing stuff as it helps understanding
the code (comments) & debug it...?

My preference would be to have a --verbose option that would generate all the extra information.
That way it can be enabled for those who like it, and disabled for those who don't. 

                
> Android app creation is broken in several ways!
> -----------------------------------------------
>
>                 Key: CB-1156
>                 URL: https://issues.apache.org/jira/browse/CB-1156
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: Android
>    Affects Versions: 2.0.0
>            Reporter: Olivier Louvignes
>            Assignee: Anis Kadri
>            Priority: Minor
>              Labels: android
>
> The experience of starting a new Android app is just really bad.
> When we use the bin/create script there is a lot of things missing :
> -> SplashScreen?!
> I just can't understand why this is lacking. It is an obvious need & everyone has
to waste time figuring out how to make it work by themselves
> -> MacOSX is broken
> Either using latest Lion or any version with Macports + GNUTools (replacing deprecated
versions bundled with OSX for licensing issues - common for most developers).
> -> The XML is missing required keys (targetSDKpath) & having invalid stuff inside
it (xLargeScreen).
> -> Most files are badly indented. Does not respect the Google guidelines for JAVA.
> I've done most of the fixing myself:
> You can find this (work in progress) there :
> - https://github.com/mgcrea/incubator-cordova-android/commits/patches-create
> I'm quite disappointed on how you release a 2.0 without taking the hour needed to clean
this mess. Instead a few hundred people will encounter the same issues & have a bad idea
on Cordova/Phonegap.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message