Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (nike.apache.org: domain of bowserj@gmail.com designates
 74.125.82.175 as permitted sender)
MIME-Version: 1.0
In-Reply-To: 
 <CAOBL_k6ibngSu5awm15qFoez-GWjNkwt3sGC-_7jotQhTWrS6Q@mail.gmail.com>
References: 
 <CAOBL_k50n0wC7Pch6MD33yYOVeW=pCcnnaZYh4WMrGSvUjbZ2A@mail.gmail.com>
	<CC09F458.8AD4%fil@adobe.com>
	<CAOBL_k6ibngSu5awm15qFoez-GWjNkwt3sGC-_7jotQhTWrS6Q@mail.gmail.com>
Date: Fri, 22 Jun 2012 10:34:50 -0700
Message-ID: 
 <CAOBL_k4k+6LoR52tXYvT4kH+yjq1MmUa6B1cY+QjvJ1gc4Dobw@mail.gmail.com>
Subject: Re: Apache Cordova Android does not compile
From: Joe Bowser <bowserj@gmail.com>
To: callback-dev@incubator.apache.org
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

Hey

I fixed the issue.  For some reason isBackButtonBound wasn't moved to
the view, and we were still using it on DroidGap when I removed the
interface.  I've moved it over and added the one line method.  I'm
going to run mobile-spec and commit it, since we should be allowing
people to check whether the back button is bound or not.

Joe

On Fri, Jun 22, 2012 at 10:20 AM, Joe Bowser <bowserj@gmail.com> wrote:
> If this fixes compilation, why not push it to master?
>
> On Jun 22, 2012 10:08 AM, "Filip Maj" <fil@adobe.com> wrote:
>>
>> Hye guys,
>>
>> I pushed a "buttonfix" branch up to apache. All I did was removed what
>> looks like unused legacy code from App.java as well as DroidGap.java. Th=
e
>> hardware key binding is now done in cordovawebview.
>>
>> Additionally, the android JS routes a call to override the back button t=
o
>> the app plugin, yes, but never actually invokes the "is the back button
>> bound" method - so it is unneeded. Therefore I removed it.
>>
>> I am going through the testing motions now but if someone wants to pull
>> down that branch and test from their end too that would be helpful.
>>
>> On 6/22/12 9:52 AM, "Joe Bowser" <bowserj@gmail.com> wrote:
>>
>> >Hey
>> >
>> >It should be using the webView.bindBackButton in app, and not the
>> >other one. =A0I think a merge of the buttons work must have messed up.
>> >I'll fix it when I get in the office this morning.
>> >
>> >Joe
>> >
>> >On Fri, Jun 22, 2012 at 9:47 AM, Filip Maj <fil@adobe.com> wrote:
>> >> 1.8.1 is a branch since cordovawebview was merged into master after
>> >>1.8.0.
>> >>
>> >> Simon I'm looking into the compilation issue.
>> >>
>> >> On 6/22/12 9:42 AM, "Brian LeRoux" <b@brian.io> wrote:
>> >>
>> >>>also: tags for 1.8.x not on the apache repo
>> >>>
>> >>>On Fri, Jun 22, 2012 at 11:38 AM, Simon MacDonald
>> >>><simon.macdonald@gmail.com> wrote:
>> >>>> Hey all,
>> >>>>
>> >>>> The recent changes to CordovaInterface where isBackButtonBound has
>> >>>> been removed is causing compilation errors. The App class is still
>> >>>> trying to call this method. Can someone who's been looking at the
>> >>>> changes to button binding on Android look into this ASAP?
>> >>>>
>> >>>> Simon Mac Donald
>> >>>> http://hi.im/simonmacdonald
>> >>
>>
>