Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Date: Wed, 13 Jun 2012 22:29:42 +0000 (UTC)
From: "Filip Maj (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: <816430180.13824.1339626582668.JavaMail.jiratomcat@issues-vm>
In-Reply-To: <702922493.13224.1339608343051.JavaMail.jiratomcat@issues-vm>
Subject: [jira] [Commented] (CB-913) Refactor Key Press Overrides on Android
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13294692#comment-13294692 ] 

Filip Maj commented on CB-913:
------------------------------

Joe, here's what I'm thinking for this. Please chime in with your thoughts.

- change CordovaInterface so that it defines a single pair of {{bindButton(boolean shouldBind, String buttonName)}} and {{isButtonBound(String buttonName)}} functions (instead of the current {{bindBackButton}} + {{isBackButtonBound}} that exist on the Interface, and the generic button functions that exist directly on DroidGap).
- add a HashTable to DroidGap that will keep track of which buttons are bound.
- Keep the current keyUp/keyDown listeners on DroidGap that would then fire off the appropriate events off into JavaScript.

Let me know what you think.
                
> Refactor Key Press Overrides on Android
> ---------------------------------------
>
>                 Key: CB-913
>                 URL: https://issues.apache.org/jira/browse/CB-913
>             Project: Apache Cordova
>          Issue Type: Sub-task
>          Components: Android
>    Affects Versions: 1.8.0
>            Reporter: Joe Bowser
>            Assignee: Filip Maj
>            Priority: Minor
>             Fix For: 1.9.0
>
>
> Currently the Volume Up and Down events are in DroidGap.java.  While this is fine for the general use case, it would be better if there was a utility class that handled these events.  This would also allow us to implement the GamePad API for the Google TV events, because Google in their infinite wisdom chose to re-implement this instead of using the standard keyCodes for Up, Down, Left and Right.
> This should fix existing bugs on Google TV, as well as make the code neater.  It also addresses CB-417.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira