Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Date: Wed, 6 Jun 2012 17:54:23 +0000 (UTC)
From: "Anis Kadri (JIRA)" <jira@apache.org>
To: callback-dev@incubator.apache.org
Message-ID: <1718800354.44337.1339005263272.JavaMail.jiratomcat@issues-vm>
In-Reply-To: 
 <185287065.1049.1333908018598.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (CB-462) Refactor accelerometer JS <-> native
 interactions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/CB-462?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13290301#comment-13290301 ] 

Anis Kadri commented on CB-462:
-------------------------------

Bada Acceleration is now broken because of this change. I had to use an older cordova.js to release 1.8. Why didn't you add a ticket for it :-( ? I guess I will create one and set it for 1.9.
                
> Refactor accelerometer JS <-> native interactions
> -------------------------------------------------
>
>                 Key: CB-462
>                 URL: https://issues.apache.org/jira/browse/CB-462
>             Project: Apache Cordova
>          Issue Type: Improvement
>          Components: CordovaJS
>    Affects Versions: 1.6.0
>            Reporter: Filip Maj
>            Assignee: Filip Maj
>             Fix For: 1.8.0
>
>
> Similar to CB-359.
> We use a completely different set of native actions to control Geolocation, Accelerometer and Compass sensor APIs. These all have identical APIs and really should be implemented in the same way.
> For accelerometer, there is no reason to need a {{setTimeout}} and {{getTimeout}} native action.
> Should use the pattern employed in CB-359 to implement the accel sensor API.
> CordovaJS should also be wrapping the error and success callbacks in {{accelerometer}} calls and making sure the right {{Acceleration}} and {{Error}} objects are passed to the user callbacks. Also need to add more unit tests to CordovaJS to be testing for all of this.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira