incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: [Android] Re-introducing getContext and deprecating
Date Tue, 26 Jun 2012 21:55:13 GMT
We did

https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a=b
lob;f=framework/src/org/apache/cordova/api/Plugin.java;h=1ac42f022c915852ad
baa43297fb17f38f427b8a;hb=HEAD#l35


Kept "ctx" for backwards compatibility
Added "cordova"

On 6/26/12 2:51 PM, "Anis KADRI" <anis.kadri@gmail.com> wrote:

>Oh and one thing why did we not rename ctx to something else like ci or
>whatever ? Something that doesn't make one believe it's a Context ?
>Because
>it is no longer a Context.
>
>On Tue, Jun 26, 2012 at 2:44 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
>> Right.  That being said, PhoneGap/Cordova users shouldn't be using
>> plugins and expecting things to just work right now.  It's an
>> experimental feature that isn't ready for primetime.  Especially since
>> pluginstall isn't officially released.
>>
>> Also, PhoneGap Build people should be on this list and should know
>> that plugins aren't 100% solid yet and plan accordingly.  We haven't
>> told anyone that plugins are solid yet, and while evangelists may be
>> trying to promote what can be done, we have to still caution people
>> for the next few weeks that plugins in 1.x are still a bit janky.
>>
>> Good thing we're doing this 2.0 thing. ;)
>>
>> On Tue, Jun 26, 2012 at 2:33 PM, Anis KADRI <anis.kadri@gmail.com>
>>wrote:
>> > I am not worried about Plugin developers, more worried about
>> > Cordova/PhoneGap users to whom we promise that they don't need to
>>touch
>> any
>> > "native" code ;-)
>> >
>> > On Tue, Jun 26, 2012 at 2:30 PM, Joe Bowser <bowserj@gmail.com> wrote:
>> >
>> >> Remember, Plugin Developers are competent enough to write Java code.
>> >> I'm not talking about the average Cordova User when I say this.
>> >>
>> >> On Tue, Jun 26, 2012 at 2:30 PM, Joe Bowser <bowserj@gmail.com>
>>wrote:
>> >> > That's fine. The fact is that we've beat this horse to death for
>>six
>> >> > months on this mailing list, in JIRA and on GitHub.  If people
>>have an
>> >> > issue with it now, they should have been more involved.
>> >> >
>> >> > Joe
>> >> >
>> >> > On Tue, Jun 26, 2012 at 2:26 PM, Anis KADRI <anis.kadri@gmail.com>
>> >> wrote:
>> >> >> Just spoke with Steve. He will inform users about this in his
>>release
>> >> blog
>> >> >> post. That's the least we can do.
>> >> >>
>> >> >> On Tue, Jun 26, 2012 at 2:21 PM, Jesse <purplecabbage@gmail.com>
>> wrote:
>> >> >>
>> >> >>> I think you should put the date that you deprecate it, not
the
>>date
>> >> that
>> >> >>> you expect to remove it ... or the version number that it is
>> >> deprecated in.
>> >> >>> We have no idea what will happen between now and December ...
>>there
>> >> may be
>> >> >>> a reason that we need to remove it sooner. ( although our
>>published
>> >> >>> deprecation policy should state that we 'intend' to keep it
>>around
>> for
>> >> 6
>> >> >>> months, we should NOT guarantee that it will be there for 6
>>months.
>> )
>> >> >>>
>> >> >>> Typically I view deprecation notices as 'Do Not Resuscitate'
>> >> >>> if keeping it around becomes more work than letting it go ...
>>then
>> let
>> >> it
>> >> >>> go ...
>> >> >>>
>> >> >>> On Tue, Jun 26, 2012 at 2:10 PM, Joe Bowser <bowserj@gmail.com>
>> wrote:
>> >> >>>
>> >> >>> > Yeah, Simon added it earlier, but then I realized that
plugins
>>are
>> >> >>> > probably already using this method, which is why I added
the
>> >> >>> > "Deprecated December 2012" message on it.
>> >> >>> >
>> >> >>> > As far as pre-1.8 versions of PhoneGap, where we provided
a
>> context
>> >> >>> > (in reality a PhoneGapActivity, which extended Activity,
which
>> >> extends
>> >> >>> > Context), I don't know of a good way to deprecate this
without
>> making
>> >> >>> > CordovaWebView completely unusable.  The thing with these
>>methods
>> is
>> >> >>> > that we decided to remove these methods before the deprecation
>> >> policy,
>> >> >>> > and I don't want to see them back in there for another
six
>>months.
>> >> >>> >
>> >> >>> > This is total Java Language Fail!
>> >> >>> >
>> >> >>> > Joe
>> >> >>> >
>> >> >>> > On Tue, Jun 26, 2012 at 12:14 PM, Brian LeRoux <b@brian.io>
>> wrote:
>> >> >>> > > thx mang, thats a good idea for the moment.
>> >> >>> > >
>> >> >>> > > On Tue, Jun 26, 2012 at 11:27 AM, Joe Bowser
>><bowserj@gmail.com
>> >
>> >> >>> wrote:
>> >> >>> > >> BTW: I added it back with this commit:
>> >> >>> > >>
>> >> >>> >
>> >> >>>
>> >>
>> 
>>https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a
>>=commit;h=58298404094c81561cf4e01b7c4397638584961b
>> >> >>> > >>
>> >> >>> > >> On Tue, Jun 26, 2012 at 11:21 AM, Joe Bowser
<
>> bowserj@gmail.com>
>> >> >>> wrote:
>> >> >>> > >>> Hey
>> >> >>> > >>>
>> >> >>> > >>> 1.9 is close to being released, but currently
plugins that
>>use
>> >> >>> > >>> ctx.getContext() are broken.  Since we changed
how a
>> >> CordovaInterface
>> >> >>> > >>> works on Android in 1.9, I'm wondering if
we should add the
>> >> >>> > >>> addContext() method back on the Interface
with a
>>deprecation
>> >> warning
>> >> >>> > >>> or just tell plugin authors that if they
aren't active on
>>the
>> >> mailing
>> >> >>> > >>> list that their plugins are going to break.
 Personally, I
>> don't
>> >> want
>> >> >>> > >>> to have more methods on the CordovaInterface,
because it
>>makes
>> >> >>> > >>> CordovaWebView harder to use, but this will
break plugins
>> across
>> >> the
>> >> >>> > >>> board.
>> >> >>> > >>>
>> >> >>> > >>> Thoughts?
>> >> >>> > >>>
>> >> >>> > >>> Joe
>> >> >>> >
>> >> >>>
>> >> >>>
>> >> >>>
>> >> >>> --
>> >> >>> @purplecabbage
>> >> >>> risingj.com
>> >> >>>
>> >>
>>


Mime
View raw message