incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Filip Maj <...@adobe.com>
Subject Re: [Android] Re-introducing getContext and deprecating
Date Tue, 26 Jun 2012 21:20:29 GMT
Yes.

On 6/26/12 2:15 PM, "Anis KADRI" <anis.kadri@gmail.com> wrote:

>still broken :-(
>
>I think old plugins expect this.ctx (as its name suggests) to be an
>instance of Context (or Activity) and not an instance of CordovaInterface.
>They are not calling ctx.getContext() to actually get the Context.
>
>So my suggestion is to just leave it broken. Plugins just have to be
>updated to use this new CordovaInterface and use getActivity to get the
>main activity right ?
>
>On Tue, Jun 26, 2012 at 12:14 PM, Brian LeRoux <b@brian.io> wrote:
>
>> thx mang, thats a good idea for the moment.
>>
>> On Tue, Jun 26, 2012 at 11:27 AM, Joe Bowser <bowserj@gmail.com> wrote:
>> > BTW: I added it back with this commit:
>> >
>> 
>>https://git-wip-us.apache.org/repos/asf?p=incubator-cordova-android.git;a
>>=commit;h=58298404094c81561cf4e01b7c4397638584961b
>> >
>> > On Tue, Jun 26, 2012 at 11:21 AM, Joe Bowser <bowserj@gmail.com>
>>wrote:
>> >> Hey
>> >>
>> >> 1.9 is close to being released, but currently plugins that use
>> >> ctx.getContext() are broken.  Since we changed how a CordovaInterface
>> >> works on Android in 1.9, I'm wondering if we should add the
>> >> addContext() method back on the Interface with a deprecation warning
>> >> or just tell plugin authors that if they aren't active on the mailing
>> >> list that their plugins are going to break.  Personally, I don't want
>> >> to have more methods on the CordovaInterface, because it makes
>> >> CordovaWebView harder to use, but this will break plugins across the
>> >> board.
>> >>
>> >> Thoughts?
>> >>
>> >> Joe
>>


Mime
View raw message