incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Becky Gibson (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (CB-448) Modify non-ascii file append test to not rely on JavaScript string length
Date Tue, 05 Jun 2012 20:28:23 GMT

     [ https://issues.apache.org/jira/browse/CB-448?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Becky Gibson resolved CB-448.
-----------------------------

       Resolution: Fixed
    Fix Version/s: 1.7.0

fixed with this commit:  https://github.com/apache/incubator-cordova-mobile-spec/commit/db377f9f2b4c5507b6eb1fcb8eb4fa029030cdef

                
> Modify non-ascii file append test to not rely on JavaScript string length
> -------------------------------------------------------------------------
>
>                 Key: CB-448
>                 URL: https://issues.apache.org/jira/browse/CB-448
>             Project: Apache Cordova
>          Issue Type: Bug
>          Components: mobile-spec
>    Affects Versions: 1.6.0
>            Reporter: Becky Gibson
>            Assignee: Becky Gibson
>             Fix For: 1.7.0
>
>
> The recently added tests in file spec to test appending to files with non-ascii data
compares the JavaScript length of the string with the FileWriter.length and FileWriter.position.
 This fails on iOS because iOS encodes the string when it writes it to the file, thus the
writer.length may not match the original JavaScript string length.  I believe that as long
as the data written matches the data read back, the write is correct and the test should pass.
 Will update the test to make that comparison rather than relying on length. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message