incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Git at Apache <>
Subject incubator-cordova-android pull request: Jira #CB-403 fix
Date Thu, 28 Jun 2012 23:26:27 GMT
GitHub user doggerelverse opened a pull request:

    Jira #CB-403 fix

    fix for the failure of seekTo on first play
    - refactoring of startPlaying
      - loadAudioFile prepares the file
      - readyPlayer attempts to put the player in the correct state for playback
    - replaced state int with enums for state tracking
    - no longer reloads audio source on every call to play
    - implement 'create' handler
    - minor changes to handle bugs caused by creating AudioPlayer on create, rather than on
play or record

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

commit 3c9415b1c2d0056cad8c2c49a0a22ceef577b11a
Author: Lorin Beer <>
Date:   2012-06-17T22:18:09-07:00

    added create message handler, updated AudioPlayer constructor usage

commit d16555ec4b0ae5bcd8e114c9cead313224d5b662
Author: Lorin Beer <>
Date:   2012-06-17T22:19:33-07:00

    added file requirement to constructor, all references to AudioPlayer constructor had direct
access to file, so this caused no other changes

commit c8bf2f4cb13adc9abeb15b97f41aa3f2137fe059
Author: Lorin Beer <>
Date:   2012-06-17T22:37:12-07:00

    removed audio load code from startPlaying to a private function

commit fc3f1431b22e0b718fff3d2221a31f9404206602
Author: Lorin Beer <>
Date:   2012-06-17T22:56:22-07:00

    made internal status static variables final as well, specifically so that they can be
used in switch statements

commit e5b9900d3b87d7b2fd9a9411234bcba8a52d1876
Author: Lorin Beer <>
Date:   2012-06-17T23:59:13-07:00

    halfway through refactor

commit d9e79842790ca1c5fa75bbfff534d2bf079cf815
Author: Lorin Beer <>
Date:   2012-06-18T10:29:56-07:00

    fixed seek behaviour, but introduces a bunch of new problems

commit 3d5e2340ca36c28899f3cf74d360500cb64016a0
Author: Lorin Beer <>
Date:   2012-06-28T15:29:23-07:00

    update to use ordinal instead of enum value

commit 0cf9f51816634de38ed5656b3344986bda666524
Author: Lorin Beer <>
Date:   2012-06-28T15:36:28-07:00

    use enums to track internal states instead of int. Fixed 'unknown state' bug with the
addition of loading state. Mega commit, lost some history.

commit 10465066ee32bcd94f7d31f72924fb09ebfdd215
Author: Lorin Beer <>
Date:   2012-06-28T15:37:11-07:00

    Merge branches 'master' and 'dev'

commit 762854ad7adb7fe53d1fc63282f2742862a6ab4a
Author: Lorin Beer <>
Date:   2012-06-28T15:53:47-07:00

    changed handling of stopRecording to reflect handling of create message

commit 3ea72e5d212cf6911cd0465d65f1edab3617e650
Author: Lorin Beer <>
Date:   2012-06-28T16:17:00-07:00

    added deleted tempfile setup


View raw message