incubator-callback-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Git at Apache <...@git.apache.org>
Subject incubator-cordova-ios pull request: Fixes CB-961- can't delete Contact arra...
Date Thu, 28 Jun 2012 13:03:20 GMT
GitHub user becka11y opened a pull request:

    https://github.com/apache/incubator-cordova-ios/pull/23

    Fixes CB-961- can't delete Contact array fields

    Remove checking for non-empty array when calling setMultiValueStrings and setMultiValueDict
    when updating phone numbers, ims, emails, urls, addresses and photos. This bug was introduced
    in the UnifiedJS conversion.
    
    This commit just reverses the bad change made during the unifiedJS conversion - should
be pretty innocuous to include in 1.9.  
    
    https://issues.apache.org/jira/browse/CB-961

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/becka11y/incubator-cordova-ios Issue961

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-cordova-ios/pull/23.patch

----
commit b6f02dea27a41d0607990c8d612913d63786d9d2
Author: Becky Gibson <becka11y@apache.org>
Date:   2012-06-27T15:16:35-07:00

    Fixes CB-961
    
    Remove checking for non-empty array when calling setMultiValueStrings and setMultiValueDict
    when updating phone numbers, ims, emails, urls, addresses and photos. This bug was introduced
    in the UnifiedJS conversion.

----


Mime
View raw message