Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm
Precedence: bulk
Reply-To: callback-dev@incubator.apache.org
Received-SPF: pass (athena.apache.org: domain of fil@adobe.com designates
 64.18.1.185 as permitted sender)
From: Filip Maj <fil@adobe.com>
To: "callback-dev@incubator.apache.org" <callback-dev@incubator.apache.org>
Date: Tue, 15 May 2012 14:17:13 -0700
Subject: Re: Java Style
Thread-Topic: Java Style
Thread-Index: Ac0y35qwixjmUnoaQ8mt6qq2RX/7kA==
Message-ID: <CBD815DD.63EA%fil@adobe.com>
In-Reply-To: 
 <CAMT1KGMkja8Tq84Rtg7ZCyZsMrP5RXAcDqeWYthYVEkJKJKnrA@mail.gmail.com>
Accept-Language: en-US
Content-Language: en-US
user-agent: Microsoft-MacOutlook/14.2.2.120421
acceptlanguage: en-US
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0

OK will add that to the style guide then. Please adjust Eclipse
accordingly, everyone!

On 5/15/12 2:12 PM, "Bryce Curtis" <curtis.bryce@gmail.com> wrote:

>+1 on 4 spaces, no tabs.
>
>On Tue, May 15, 2012 at 4:07 PM, Michael Brooks
><michael@michaelbrooks.ca> wrote:
>> +1 on 4 spaces in Java.
>>
>> On Tue, May 15, 2012 at 1:55 PM, Joe Bowser <bowserj@gmail.com> wrote:
>>
>>> +1 on spaces.  It should be noted that this isn't the default in
>>>Eclipse.
>>> :(
>>>
>>> On Tue, May 15, 2012 at 1:52 PM, Drew Walters <deedubbu@gmail.com>
>>>wrote:
>>>
>>> > Should note, all the BlackBerry Java code is 4 space indentation
>>> > except for maybe a few spots where someone else edited the file.
>>> >
>>> > On Tue, May 15, 2012 at 3:50 PM, Drew Walters <deedubbu@gmail.com>
>>> wrote:
>>> > > +1 spaces
>>> > >
>>> > > On Tue, May 15, 2012 at 3:48 PM, Shazron <shazron@gmail.com> wrote:
>>> > >> Spaces.
>>> > >> I've an issue filed against iOS regarding this:
>>> > >> https://issues.apache.org/jira/browse/CB-625
>>> > >>
>>> > >>
>>> > >> On Tue, May 15, 2012 at 1:49 PM, Filip Maj <fil@adobe.com> wrote:
>>> > >>> I suppose I should post my refs too
>>> > >>>
>>> > >>> [1] http://wiki.apache.org/cordova/StyleGuide
>>> > >>> [2]
>>> > >>>
>>> >
>>>=20
>>>http://www.oracle.com/technetwork/java/javase/documentation/codeconventi
>>>ons
>>> > >>> -136091.html#262
>>> > >>>
>>> > >>> On 5/15/12 1:48 PM, "Filip Maj" <fil@adobe.com> wrote:
>>> > >>>
>>> > >>>>Let's see how this one pans out ;)
>>> > >>>>
>>> > >>>>This came up during the code review of the CordovaWebView stuff
>>>for
>>> > >>>>Android. Our style guide [1] specifies to follow the Eclipse
>>>Coding
>>> > >>>>Conventions, which point to standards set out by Sun, which of
>>>course
>>> > now
>>> > >>>>points to an Oracle web site.
>>> > >>>>
>>> > >>>>The Sun standards say [2] about indentation:
>>> > >>>>
>>> > >>>>----
>>> > >>>>
>>> > >>>>4 - Indentation
>>> > >>>>
>>> > >>>>Four spaces should be used as the unit of indentation. The exact
>>> > >>>>construction of the indentation (spaces vs. tabs) is unspecified.
>>> Tabs
>>> > >>>>must be set exactly every 8 spaces (not 4).
>>> > >>>>
>>> > >>>>----
>>> > >>>>
>>> > >>>>
>>> > >>>>So my question is: tabs or spaces in Java code?
>>> > >>>>
>>> > >>>>My vote: spaces.
>>> > >>>>
>>> > >>>>Let your voice be heard.
>>> > >>>>
>>> > >>>
>>> >
>>>