Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id A6333927E for ; Wed, 23 May 2012 19:53:34 +0000 (UTC) Received: (qmail 45165 invoked by uid 500); 23 May 2012 19:53:34 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 45145 invoked by uid 500); 23 May 2012 19:53:34 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 45137 invoked by uid 99); 23 May 2012 19:53:34 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2012 19:53:34 +0000 X-ASF-Spam-Status: No, hits=0.3 required=5.0 tests=FREEMAIL_REPLY,RCVD_IN_DNSWL_LOW,SPF_PASS X-Spam-Check-By: apache.org Received-SPF: pass (nike.apache.org: domain of simon.macdonald@gmail.com designates 209.85.160.47 as permitted sender) Received: from [209.85.160.47] (HELO mail-pb0-f47.google.com) (209.85.160.47) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 23 May 2012 19:53:28 +0000 Received: by pbbrq2 with SMTP id rq2so9358766pbb.6 for ; Wed, 23 May 2012 12:53:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :content-type:content-transfer-encoding; bh=/KynXGuPDm/CkjV4jH5+iGSYcl1A1emAoZJZ3C4g9SU=; b=TnxLTBkrIcgibAy++DzpxPhjNiqT4ec/5h75VJDB5Ni60uu9aWewbIU3uotBhBcuoy O2O6PEetOH2/6HN46ek+F0PhzMd4CMyJMpJYTozg5yvnCr8OZ6efLkOI8ZE3xO7o16ir l4XsxK5JKRm3IiOZVKYJ6CzIfdXnPq2J+KN1ZO1pv+Ozx0crkL51yrkuLfyNByYojBKs A4haXHYppfjU3EuYSLEeZErEIljqHzNInw3cmpYJI70GitGgB1hSo4LrZr2GY7h5L5ZU uzTVCZ5CBRsxapAhWpdVe4Ngply5mE/k5RtJughCgWnpx+rikcrRGPaEYS4/feNSOD01 JHHg== Received: by 10.68.221.74 with SMTP id qc10mr13444434pbc.31.1337802786976; Wed, 23 May 2012 12:53:06 -0700 (PDT) MIME-Version: 1.0 Received: by 10.68.202.35 with HTTP; Wed, 23 May 2012 12:52:46 -0700 (PDT) In-Reply-To: References: From: Simon MacDonald Date: Wed, 23 May 2012 15:52:46 -0400 Message-ID: Subject: Re: Adding HTTP status code to FileTransferError To: callback-dev@incubator.apache.org Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable I'll do the Android one today. Simon Mac Donald http://hi.im/simonmacdonald On Wed, May 23, 2012 at 3:27 PM, Don Coleman wrote: > So would it make sense to re-assign the completed tickets to the > platform maintainers? > > Are these the right people? > > iOS - Shazron > Android - Joe > Webworks - Michael > Mobile Spec - Fil > > On Wed, May 23, 2012 at 2:46 PM, Shazron wrote: >> This shouldn't be closed until all pull requests + issue subtasks are >> resolved. I would assume the platform maintainers will resolve the >> sub-tasks. Once the sub-tasks are resolved, the parent issue can be clos= ed. >> >> On Wed, May 23, 2012 at 11:42 AM, Don Coleman wr= ote: >> >>> I've created pull requests on github for iOS, Android and Webworks >>> >>> Should I close (or resolve) the JIRA ticket? =A0Or do I assign them to >>> someone else? >>> >>> https://issues.apache.org/jira/browse/CB-790 >>> >>> On Fri, May 18, 2012 at 1:12 PM, Simon MacDonald >>> wrote: >>> > Never mind I realize now that Don sent it to the right place. Fil and >>> > I were CC'ed on it. >>> > >>> > Simon Mac Donald >>> > http://hi.im/simonmacdonald >>> > >>> > >>> > On Fri, May 18, 2012 at 1:06 PM, Simon MacDonald >>> > wrote: >>> >> It's here: >>> >> >>> >> https://people.apache.org/committer-index.html >>> >> >>> >> Don sent me the CLA and I'm going to forward it to the right place. >>> >> >>> >> Simon Mac Donald >>> >> http://hi.im/simonmacdonald >>> >> >>> >> >>> >> On Fri, May 18, 2012 at 1:07 PM, Filip Maj wrote: >>> >>> Where do we check the list of people who've submitted the CLA? >>> >>> >>> >>> On 5/17/12 7:09 PM, "Simon MacDonald" >>> wrote: >>> >>> >>> >>>>I may have missed it but did you sign the Apache CLA? IIRC we need >>> >>>>this before we can merge your pull requests. >>> >>>> >>> >>>>Simon Mac Donald >>> >>>>http://hi.im/simonmacdonald >>> >>>> >>> >>>> >>> >>>>On Thu, May 17, 2012 at 9:33 PM, Don Coleman >>> >>>>wrote: >>> >>>>> What's the workflow for fixing issues? >>> >>>>> >>> >>>>> I issued pull requests on Github. =A0(Should these go to Apache >>> instead?) >>> >>>>> >>> >>>>> Do I mark the JIRA issues as resolved or assign it to someone? >>> >>>>> >>> >>>>> android - >>> https://github.com/apache/incubator-cordova-android/pull/22 >>> >>>>> iOS - https://github.com/apache/incubator-cordova-ios/pull/18 >>> >>>>> mobile-spec - >>> >>>>>https://github.com/apache/incubator-cordova-mobile-spec/pull/6 >>> >>>>> >>> >>>>> On Tue, May 15, 2012 at 9:09 PM, Shazron wrot= e: >>> >>>>>> done >>> >>>>>> >>> >>>>>> On Tue, May 15, 2012 at 5:48 PM, Don Coleman >> > >>> >>>>>>wrote: >>> >>>>>>> Created https://issues.apache.org/jira/browse/CB-790 >>> >>>>>>> >>> >>>>>>> Can someone assign it to me? >>> >>>>>>> >>> >>>>>>> On Tue, May 15, 2012 at 2:02 PM, Filip Maj wrot= e: >>> >>>>>>>> We can drop issues into the issue tracker for the missing >>> platforms >>> >>>>>>>>and >>> >>>>>>>> hopefully our platform implementers will have time to get it i= n >>> for >>> >>>>>>>>1.8. >>> >>>>>>>> >>> >>>>>>>> On 5/15/12 10:47 AM, "Don Coleman" wro= te: >>> >>>>>>>> >>> >>>>>>>>>I should be able to get most of these changes this week. =A0Af= ter >>> >>>>>>>>>looking the Blackberry code, I need to redo the Android patch. >>> I'll >>> >>>>>>>>>look at WP7 tomorrow. =A0Symbian, Bada, et al may be more >>> challenging >>> >>>>>>>>>since I don't have test devices. >>> >>>>>>>>> >>> >>>>>>>>>On Tue, May 15, 2012 at 11:56 AM, Filip Maj >>> wrote: >>> >>>>>>>>>> Sure. Thanks for taking the lead on this one Don. With your >>> help we >>> >>>>>>>>>>should >>> >>>>>>>>>> be able to get this in for 1.8, possibly even for the RC >>> >>>>>>>>>>(presumably >>> >>>>>>>>>>later >>> >>>>>>>>>> this week?) >>> >>>>>>>>>> >>> >>>>>>>>>> On 5/14/12 8:20 PM, "Don Coleman" >>> wrote: >>> >>>>>>>>>> >>> >>>>>>>>>>>Should I create an JIRA ticket for this? >>> >>>>>>>>>>> >>> >>>>>>>>>>> >>> https://github.com/don/incubator-cordova-mobile-spec/tree/FileTrans >>> >>>>>>>>>>>ferEr >>> >>>>>>>>>>>ro >>> >>>>>>>>>>>r >>> >>>>>>>>>>> >>> https://github.com/don/incubator-cordova-ios/tree/FileTransferError >>> >>>>>>>>>>> >>> https://github.com/don/incubator-cordova-android/tree/FileTransferE >>> >>>>>>>>>>>rror >>> >>>>>>>>>>> >>> >>>>>>>>>>>I need to clean up the Android version before issuing a pull >>> >>>>>>>>>>>request. >>> >>>>>>>>>>> >>> >>>>>>>>>>>I'll take a look at WP7 tomorrow. >>> >>>>>>>>>>> >>> >>>>>>>>>>>On Mon, May 14, 2012 at 3:00 PM, Joe Bowser >>> >>>>>>>>>>>wrote: >>> >>>>>>>>>>>> +1 >>> >>>>>>>>>>>> >>> >>>>>>>>>>>> On Mon, May 14, 2012 at 11:54 AM, Shazron >>> >>>>>>>>>>>>wrote: >>> >>>>>>>>>>>> >>> >>>>>>>>>>>>> +1 >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>> On Mon, May 14, 2012 at 11:56 AM, Filip Maj >>> >>>>>>>>>>>>>wrote: >>> >>>>>>>>>>>>> > +1 ! >>> >>>>>>>>>>>>> > >>> >>>>>>>>>>>>> > On 5/14/12 11:50 AM, "Simon MacDonald" >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>> wrote: >>> >>>>>>>>>>>>> > >>> >>>>>>>>>>>>> >>Sounds good to me. I'd probably skip the "http_message"= as >>> you >>> >>>>>>>>>>>>>pretty >>> >>>>>>>>>>>>> much >>> >>>>>>>>>>>>> >>get all you need from the status and you don't need to >>> >>>>>>>>>>>>>localize the >>> >>>>>>>>>>>>> >>string. >>> >>>>>>>>>>>>> >> >>> >>>>>>>>>>>>> >>Simon Mac Donald >>> >>>>>>>>>>>>> >>http://hi.im/simonmacdonald >>> >>>>>>>>>>>>> >> >>> >>>>>>>>>>>>> >> >>> >>>>>>>>>>>>> >>On Mon, May 14, 2012 at 9:29 AM, Don Coleman >>> >>>>>>>>>>>>> >>> >>>>>>>>>>>>> >>wrote: >>> >>>>>>>>>>>>> >> >>> >>>>>>>>>>>>> >>> I'd like to add HTTP Status Code and HTTP Status Mess= age >>> to >>> >>>>>>>>>>>>> >>> FileTransferError. >>> >>>>>>>>>>>>> >>> >>> >>>>>>>>>>>>> >>> Any objections? >>> >>>>>>>>>>>>> >>> >>> >>>>>>>>>>>>> >>> { >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "code": FILE_NOT_FOUND_ERR >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "source": "http://example.com/missing.txt= ", >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "target": "file:///mnt/sdcard/foo.txt", >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "http_status": 404 >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "http_message": "Not Found" >>> >>>>>>>>>>>>> >>> } >>> >>>>>>>>>>>>> >>> >>> >>>>>>>>>>>>> >>> { >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "code": CONNECTION_ERR >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "source": "http://example.com/protected.t= xt", >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "target": "file:///mnt/sdcard/bar.txt", >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "http_status": 401 >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "http_message": "Authorization Required" >>> >>>>>>>>>>>>> >>> } >>> >>>>>>>>>>>>> >>> >>> >>>>>>>>>>>>> >>> { >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "code": CONNECTION_ERR >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "source": "http://example.com/admin.txt", >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "target": "file:///mnt/sdcard/baz.txt", >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "http_status": 403 >>> >>>>>>>>>>>>> >>> =A0 =A0 =A0 "http_message": "Forbidden" >>> >>>>>>>>>>>>> >>> } >>> >>>>>>>>>>>>> >>> >>> >>>>>>>>>>>>> > >>> >>>>>>>>>>>>> >>> >>>>>>>>>> >>> >>>>>>>> >>> >>> >>>