From callback-dev-return-6097-apmail-incubator-callback-dev-archive=incubator.apache.org@incubator.apache.org Tue May 1 20:39:18 2012 Return-Path: X-Original-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Delivered-To: apmail-incubator-callback-dev-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 5455C9CB2 for ; Tue, 1 May 2012 20:39:18 +0000 (UTC) Received: (qmail 75253 invoked by uid 500); 1 May 2012 20:39:17 -0000 Delivered-To: apmail-incubator-callback-dev-archive@incubator.apache.org Received: (qmail 75192 invoked by uid 500); 1 May 2012 20:39:17 -0000 Mailing-List: contact callback-dev-help@incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: callback-dev@incubator.apache.org Delivered-To: mailing list callback-dev@incubator.apache.org Received: (qmail 75057 invoked by uid 99); 1 May 2012 20:39:17 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2012 20:39:17 +0000 X-ASF-Spam-Status: No, hits=-2000.0 required=5.0 tests=ALL_TRUSTED,T_RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 01 May 2012 20:39:15 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id C1E7642AC7C for ; Tue, 1 May 2012 20:38:54 +0000 (UTC) Date: Tue, 1 May 2012 20:38:54 +0000 (UTC) From: "Shazron Abdullah (JIRA)" To: callback-dev@incubator.apache.org Message-ID: <29057534.14490.1335904734806.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1575645921.24570.1330989357942.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (CB-298) DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/CB-298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13266057#comment-13266057 ] Shazron Abdullah commented on CB-298: ------------------------------------- Did you see my comment: --------------------- Found the problem, it's a timing issue: Before this function is called: https://github.com/apache/incubator-cordova-js/blob/master/lib/cordova.js#L281 ... cordova.exec is not defined yet. --------------------- I understand how deprecateFunctions works - in this case however, it can't "add" a deprecation notice to .exec because the function doesn't exist in the cordova object at this point. In any case, adding the PhoneGap and Cordova globals in common/common.js would suffice without adding the (if (!window.PhoneGap)) in lib/cordova.js since deprecateFunctions does not work (because of the reason I mentioned in the previous paragraph). > DEPRECATE "plugins" and "PhoneGap" global objects in JavaScript implementation > ------------------------------------------------------------------------------ > > Key: CB-298 > URL: https://issues.apache.org/jira/browse/CB-298 > Project: Apache Callback > Issue Type: Improvement > Components: CordovaJS > Affects Versions: 1.4.0, 1.5.0, 1.6.0 > Reporter: Filip Maj > Assignee: Shazron Abdullah > Priority: Minor > Labels: api-change, javascript > Fix For: 1.7.0 > > > There are two globals currently defined in Cordova-JS' common platform definition, which get dropped onto the `window` object: `plugins` and `PhoneGap`. > Let's slate these for removal. > In 1.6, let's set up deprecation notices for these. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira